All of lore.kernel.org
 help / color / mirror / Atom feed
* out-of-tree module shouldn't disable lockdep
@ 2011-12-22 16:59 Tejun Heo
  2011-12-22 17:07 ` Tejun Heo
  0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2011-12-22 16:59 UTC (permalink / raw)
  To: Ben Hutchings, Dave Jones, Greg Kroah-Hartman, Rusty Russell,
	Peter Zijlstra, Ingo Molnar
  Cc: linux-kernel

Hello, guys.

2449b8ba074 "module,bug: Add TAINT_OOT_MODULE flag for modules not
built in-tree" added TAINT_OOT_MODULE to mark kernel which has
out-of-tree module loaded, which might be a good idea but an
unfortunate side effect of tainting is that it disables lockdep.  So,
now, none of my test modules is watched by lockdep.  This is a bad bad
idea.  People use oot modules to write test code and disabling lockdep
for test codes is silly.  Can we please fix this?

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: out-of-tree module shouldn't disable lockdep
  2011-12-22 16:59 out-of-tree module shouldn't disable lockdep Tejun Heo
@ 2011-12-22 17:07 ` Tejun Heo
  0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2011-12-22 17:07 UTC (permalink / raw)
  To: Ben Hutchings, Dave Jones, Greg Kroah-Hartman, Rusty Russell,
	Peter Zijlstra, Ingo Molnar
  Cc: linux-kernel

On Thu, Dec 22, 2011 at 08:59:52AM -0800, Tejun Heo wrote:
> Hello, guys.
> 
> 2449b8ba074 "module,bug: Add TAINT_OOT_MODULE flag for modules not
> built in-tree" added TAINT_OOT_MODULE to mark kernel which has
> out-of-tree module loaded, which might be a good idea but an
> unfortunate side effect of tainting is that it disables lockdep.  So,
> now, none of my test modules is watched by lockdep.  This is a bad bad
> idea.  People use oot modules to write test code and disabling lockdep
> for test codes is silly.  Can we please fix this?

Ingo just told me it's already fixed and scheduled for upstream, so
please forget about this thread.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-12-22 17:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-22 16:59 out-of-tree module shouldn't disable lockdep Tejun Heo
2011-12-22 17:07 ` Tejun Heo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.