From: Marcelo Tosatti <mtosatti@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org, takuya.yoshikawa@gmail.com
Subject: Re: [PATCH 3/4] KVM: Count the number of dirty pages for dirty logging
Date: Fri, 23 Dec 2011 09:14:51 -0200 [thread overview]
Message-ID: <20111223111451.GD24308@amt.cnet> (raw)
In-Reply-To: <4EF00F2F.6080305@oss.ntt.co.jp>
On Tue, Dec 20, 2011 at 01:29:35PM +0900, Takuya Yoshikawa wrote:
> (2011/11/14 19:07), Avi Kivity wrote:
> >>@@ -1491,7 +1492,8 @@ void mark_page_dirty_in_slot(struct kvm *kvm, struct kvm_memory_slot *memslot,
> >> if (memslot&& memslot->dirty_bitmap) {
> >> unsigned long rel_gfn = gfn - memslot->base_gfn;
> >>
> >>- __set_bit_le(rel_gfn, memslot->dirty_bitmap);
> >>+ if (!__test_and_set_bit_le(rel_gfn, memslot->dirty_bitmap))
> >>+ memslot->nr_dirty_pages++;
> >> }
> >> }
> >>
>
> [snip]
>
> >btw mark_page_dirty() itself seems to assume mmu_lock protection that
> >doesn't exist. Marcelo?
> >
Not mmu_lock protection, kvm->srcu protection.
> I want to hear the answer for this question.
>
> Though I myself is reading the code, I cannot understand it thoroughly yet.
> I wish if there were mmu_lock entry in locking.txt ...
Agreed.
next prev parent reply other threads:[~2011-12-23 11:38 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 9:20 [PATCH 0/4] KVM: Dirty logging optimization using rmap Takuya Yoshikawa
2011-11-14 9:21 ` [PATCH 1/4] KVM: MMU: Clean up BUG_ON() conditions in rmap_write_protect() Takuya Yoshikawa
2011-11-14 9:22 ` [PATCH 2/4] KVM: MMU: Split gfn_to_rmap() into two functions Takuya Yoshikawa
2011-11-14 9:23 ` [PATCH 3/4] KVM: Count the number of dirty pages for dirty logging Takuya Yoshikawa
2011-11-14 10:07 ` Avi Kivity
2011-11-14 10:24 ` Avi Kivity
2011-12-20 4:29 ` Takuya Yoshikawa
2011-12-23 11:14 ` Marcelo Tosatti [this message]
2011-12-24 2:52 ` Takuya Yoshikawa
2011-12-27 13:50 ` Marcelo Tosatti
2011-12-27 14:03 ` Avi Kivity
2011-12-27 15:03 ` Takuya Yoshikawa
2011-12-27 15:06 ` Avi Kivity
2011-12-27 15:15 ` Takuya Yoshikawa
2011-12-27 15:18 ` Avi Kivity
2011-11-14 9:24 ` [PATCH 4/4] KVM: Optimize dirty logging by rmap_write_protect() Takuya Yoshikawa
2011-11-14 10:22 ` Avi Kivity
2011-11-14 10:29 ` Takuya Yoshikawa
2011-11-14 10:25 ` [PATCH 0/4] KVM: Dirty logging optimization using rmap Avi Kivity
2011-11-14 10:56 ` Takuya Yoshikawa
2011-11-14 12:39 ` Avi Kivity
2011-11-16 4:28 ` Takuya Yoshikawa
2011-11-16 9:06 ` Avi Kivity
2011-11-29 10:01 ` Xiao Guangrong
2011-11-29 10:09 ` Xiao Guangrong
2011-11-29 10:35 ` Takuya Yoshikawa
2011-11-29 11:20 ` Avi Kivity
2011-11-29 11:56 ` Xiao Guangrong
2011-11-29 12:01 ` Avi Kivity
2011-11-29 14:03 ` Avi Kivity
2011-11-30 5:02 ` Takuya Yoshikawa
2011-11-30 5:02 ` [Qemu-devel] " Takuya Yoshikawa
2011-11-30 5:15 ` Takuya Yoshikawa
2011-11-30 5:15 ` [Qemu-devel] " Takuya Yoshikawa
2011-12-01 15:18 ` Avi Kivity
2011-12-01 15:18 ` [Qemu-devel] " Avi Kivity
2011-12-03 4:37 ` Takuya Yoshikawa
2011-12-03 4:37 ` [Qemu-devel] " Takuya Yoshikawa
2011-12-04 10:20 ` Avi Kivity
2011-12-04 10:20 ` [Qemu-devel] " Avi Kivity
2011-11-30 7:10 ` Xiao Guangrong
2011-11-30 7:03 ` Xiao Guangrong
2011-12-01 15:11 ` Avi Kivity
2011-11-16 8:17 ` Takuya Yoshikawa
2011-11-16 8:17 ` [Qemu-devel] " Takuya Yoshikawa
2011-11-17 9:28 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111223111451.GD24308@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.