Re: [PATCH 14 of 16] libxl: bind virtual bdf to physical bdf after device assignment

[Wei Wang2 <wei.wang2@amd.com>]

On Friday 23 December 2011 12:37:17 Ian Campbell wrote:
> On Fri, 2011-12-23 at 11:29 +0000, Wei Wang wrote:
> > # HG changeset patch
> > # User Wei Wang <wei.wang2@amd.com>
> > # Date 1324569415 -3600
> > # Node ID 7ac92c11a11a4dbdf85ef503445128be861cb400
> > # Parent  00bdad5dfb7f5efd0b1cc54622b3ccb1b1b1b16f
> > libxl: bind virtual bdf to physical bdf after device assignment
> >
> > Signed-off-by: Wei Wang <wei.wang2@amd.com>
> >
> > diff -r 00bdad5dfb7f -r 7ac92c11a11a tools/libxl/libxl_pci.c
> > --- a/tools/libxl/libxl_pci.c	Thu Dec 22 16:56:52 2011 +0100
> > +++ b/tools/libxl/libxl_pci.c	Thu Dec 22 16:56:55 2011 +0100
> > @@ -735,6 +735,13 @@ out:
> >              LIBXL__LOG_ERRNOVAL(ctx, LIBXL__LOG_ERROR, rc,
> > "xc_assign_device failed"); return ERROR_FAIL;
> >          }
> > +        if (LIBXL__DOMAIN_IS_TYPE(gc,  domid, HVM)) {
> > +            rc = xc_domain_bind_pt_bdf(ctx->xch, domid, pcidev->vdevfn,
> > pcidev_encode_bdf(pcidev)); +            if ( rc ) {
> > +            LIBXL__LOG_ERRNOVAL(ctx, LIBXL__LOG_ERROR, rc,
> > "xc_domain_bind_pt_bdf failed"); +            return ERROR_FAIL;
> > +            }
> > +        }
>
> Indentation is wrong here, or you've used hard tabs where you need 4
> spaces.
Yes, indeed. I will fix it.
Thanks,
Wei

> Ian.