Re: [PATCH 14 of 14 V3] libxl: Introduce a new guest config file parameter

[Wei Wang2 <wei.wang2@amd.com>]

On Wednesday 11 January 2012 09:43:44 Ian Campbell wrote:
> On Tue, 2012-01-10 at 17:07 +0000, Wei Wang wrote:
> > # HG changeset patch
> > # User Wei Wang <wei.wang2@amd.com>
> > # Date 1326213623 -3600
> > # Node ID 39eb093ea89eeaa4dbff29439499f2a289291ff0
> > # Parent  9e89b6485b6c91a8d563c46c47a8d768eee7d1f2
> > libxl: Introduce a new guest config file parameter
> > Use iommu = {1,0} to enable or disable guest iommu emulation.
> > Default value is 0.
>
> Please patch docs/man/xl.cfg.pod.5 to explain this new option to the
> users, when/why they would enable it etc.
Sure, will do that

> A description of the hardware requirements might be useful, although
> perhaps not in that document. Likewise the guest OS requirements. Is
> there a passthru page on the wiki which could be amended?
I could add new section in http://wiki.xen.org/wiki/VTdHowTo 
describing how to use iommu emulation for ats/gpgpu passthru and the hw/sw 
requirement. 

> > Signed-off-by: Wei Wang <wei.wang2@amd.com>
>
> [...]
>
> > diff -r 9e89b6485b6c -r 39eb093ea89e tools/libxl/xl_cmdimpl.c
> > --- a/tools/libxl/xl_cmdimpl.c	Tue Jan 10 17:40:20 2012 +0100
> > +++ b/tools/libxl/xl_cmdimpl.c	Tue Jan 10 17:40:23 2012 +0100
> > @@ -360,6 +360,7 @@ static void printf_info(int domid,
> >          printf("\t\t\t(vpt_align %d)\n", b_info->u.hvm.vpt_align);
> >          printf("\t\t\t(timer_mode %d)\n", b_info->u.hvm.timer_mode);
> >          printf("\t\t\t(nestedhvm %d)\n", b_info->u.hvm.nested_hvm);
> > +        printf("\t\t\t(iommu %d)\n", b_info->u.hvm.iommu);
>
> I wonder if we should stop adding new stuff to this output, it's for
> legacy users anyway.
Sounds like I could remove it..

Thanks
Wei

> Ian.