All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] post/lib_powerpc/multi.c: make checkpatch clean
Date: Fri, 23 Dec 2011 13:39:52 +0100	[thread overview]
Message-ID: <20111223133952.5e09a8b4@wker> (raw)
In-Reply-To: <1324639752-26856-1-git-send-email-wd@denx.de>

Hello Wolfgang,

Looks good. A minor commend below.

On Fri, 23 Dec 2011 12:29:10 +0100
Wolfgang Denk <wd@denx.de> wrote:

> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Anatolij Gustschin <agust@denx.de>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Kumar Gala <galak@kernel.crashing.org>
> Cc: Kim Phillips <kim.phillips@freescale.com>
> Cc: Andy Fleming <afleming@gmail.com>
> ---
>  post/lib_powerpc/multi.c |   54 +++++++++++++++++++++------------------------
>  1 files changed, 25 insertions(+), 29 deletions(-)
> 
> diff --git a/post/lib_powerpc/multi.c b/post/lib_powerpc/multi.c
> index 5845616..4b4b119 100644
> --- a/post/lib_powerpc/multi.c
> +++ b/post/lib_powerpc/multi.c
> @@ -38,45 +38,41 @@
>  
>  #if CONFIG_POST & CONFIG_SYS_POST_CPU
>  
> -extern void cpu_post_exec_02 (ulong *code, ulong op1, ulong op2);
> +extern void cpu_post_exec_02(ulong * code, ulong op1, ulong op2);

IIRC checkpatch complains like "foo * bar" should be "foo *bar",
There is surely no need to resubmit the patch, it could be changed
when applying. Otherwise

Acked-by: Anatolij Gustschin <agust@denx.de>

Thanks,
Anatolij

  parent reply	other threads:[~2011-12-23 12:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-22 23:21 [U-Boot] CPU POST on MPC5200 fails with U-Boot built using GCC 4.6.1 Anatolij Gustschin
2011-12-23 11:29 ` [U-Boot] [PATCH 1/3] post/lib_powerpc/multi.c: make checkpatch clean Wolfgang Denk
2011-12-23 11:29   ` [U-Boot] [PATCH 2/3] post/lib_powerpc/multi.c: code cleanup Wolfgang Denk
2011-12-23 12:45     ` Anatolij Gustschin
2011-12-23 19:07     ` Wolfgang Denk
2011-12-23 11:29   ` [U-Boot] [PATCH 3/3] post/lib_powerpc/multi.c: fix stack overflow error Wolfgang Denk
2011-12-23 16:06     ` Anatolij Gustschin
2011-12-23 19:10       ` Wolfgang Denk
2011-12-23 19:08     ` Wolfgang Denk
2011-12-23 12:39   ` Anatolij Gustschin [this message]
2011-12-23 19:07     ` [U-Boot] [PATCH 1/3] post/lib_powerpc/multi.c: make checkpatch clean Wolfgang Denk
2011-12-23 19:06   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111223133952.5e09a8b4@wker \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.