All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] post/lib_powerpc/multi.c: fix stack overflow error
Date: Fri, 23 Dec 2011 20:08:14 +0100	[thread overview]
Message-ID: <20111223190814.B078E166C892@gemini.denx.de> (raw)
In-Reply-To: <1324639752-26856-3-git-send-email-wd@denx.de>

Dear Wolfgang Denk,

In message <1324639752-26856-3-git-send-email-wd@denx.de> you wrote:
> The code and comment disagreed: the comment claimed that r6...r31
> were copied, and consequently the arrays for "src" and "dst" were
> declared with 26 entries, but the actual code ("lmw r5,0(r3)" and
> "stmw r5,0(r4)") copied _27_ words (r5 through r31), which resulted
> in false "POST cpu Error at multi test" messages.
> 
> Fix the comment and the array sizes.
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Anatolij Gustschin <agust@denx.de>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Kumar Gala <galak@kernel.crashing.org>
> Cc: Kim Phillips <kim.phillips@freescale.com>
> Cc: Andy Fleming <afleming@gmail.com>
> ---
>  post/lib_powerpc/multi.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Love is an ideal thing, marriage a real thing; a  confusion  of  the
real with the ideal never goes unpunished."                  - Goethe

  parent reply	other threads:[~2011-12-23 19:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-22 23:21 [U-Boot] CPU POST on MPC5200 fails with U-Boot built using GCC 4.6.1 Anatolij Gustschin
2011-12-23 11:29 ` [U-Boot] [PATCH 1/3] post/lib_powerpc/multi.c: make checkpatch clean Wolfgang Denk
2011-12-23 11:29   ` [U-Boot] [PATCH 2/3] post/lib_powerpc/multi.c: code cleanup Wolfgang Denk
2011-12-23 12:45     ` Anatolij Gustschin
2011-12-23 19:07     ` Wolfgang Denk
2011-12-23 11:29   ` [U-Boot] [PATCH 3/3] post/lib_powerpc/multi.c: fix stack overflow error Wolfgang Denk
2011-12-23 16:06     ` Anatolij Gustschin
2011-12-23 19:10       ` Wolfgang Denk
2011-12-23 19:08     ` Wolfgang Denk [this message]
2011-12-23 12:39   ` [U-Boot] [PATCH 1/3] post/lib_powerpc/multi.c: make checkpatch clean Anatolij Gustschin
2011-12-23 19:07     ` Wolfgang Denk
2011-12-23 19:06   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111223190814.B078E166C892@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.