From: Alec Moskvin <alecmn@gmail.com>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] hid_wiimote: add INPUT_FF_MEMLESS dependency
Date: Sun, 25 Dec 2011 11:13:20 -0500 [thread overview]
Message-ID: <20111225161320.GA12841@thinkpad> (raw)
In-Reply-To: <CANq1E4Qab2sO2QagwmU-66+kUWhpStxVWawEGX=1HCdrM7bgLA@mail.gmail.com>
Hi David,
On Sunday 25 December 2011 11:06:58, David Herrmann wrote:
> Hi Alec
>
> On Sat, Dec 24, 2011 at 5:42 PM, Alec Moskvin <alecmn@gmail.com> wrote:
> > This fixes build error:
> > ...
> > CRC 17a7c33e
> > Kernel: arch/x86/boot/bzImage is ready (#1)
> > Building modules, stage 2.
> > MODPOST 7 modules
> > ERROR: "input_ff_create_memless" [drivers/hid/hid-wiimote.ko]
> > undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> >
> > Signed-off-by: Alec Moskvin <alecmn@gmail.com>
> > ---
> > drivers/hid/Kconfig | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> > index 22a4a05..332c22a 100644
> > --- a/drivers/hid/Kconfig
> > +++ b/drivers/hid/Kconfig
> > @@ -620,6 +620,7 @@ config HID_WIIMOTE
> > depends on BT_HIDP
> > depends on LEDS_CLASS
> > select POWER_SUPPLY
> > + select INPUT_FF_MEMLESS
> > ---help---
> > Support for the Nintendo Wii Remote bluetooth device.
> >
>
> This fix is already in Jiri's tree. See here:
> http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=commitdiff;h=ef6f41157f3864d9bf42671b2ed66062dcafb72e
>
> Regards
> David
I wasn't aware of that. Shouldn't it be pushed to the main tree, then?
It's not in 3.2-rc7 (released yesterday), which is why I reported it.
Thanks,
Alec
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Alec Moskvin <alecmn@gmail.com>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] hid_wiimote: add INPUT_FF_MEMLESS dependency
Date: Sun, 25 Dec 2011 11:13:20 -0500 [thread overview]
Message-ID: <20111225161320.GA12841@thinkpad> (raw)
In-Reply-To: <CANq1E4Qab2sO2QagwmU-66+kUWhpStxVWawEGX=1HCdrM7bgLA@mail.gmail.com>
Hi David,
On Sunday 25 December 2011 11:06:58, David Herrmann wrote:
> Hi Alec
>
> On Sat, Dec 24, 2011 at 5:42 PM, Alec Moskvin <alecmn@gmail.com> wrote:
> > This fixes build error:
> > ...
> > CRC 17a7c33e
> > Kernel: arch/x86/boot/bzImage is ready (#1)
> > Building modules, stage 2.
> > MODPOST 7 modules
> > ERROR: "input_ff_create_memless" [drivers/hid/hid-wiimote.ko]
> > undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> >
> > Signed-off-by: Alec Moskvin <alecmn@gmail.com>
> > ---
> > drivers/hid/Kconfig | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> > index 22a4a05..332c22a 100644
> > --- a/drivers/hid/Kconfig
> > +++ b/drivers/hid/Kconfig
> > @@ -620,6 +620,7 @@ config HID_WIIMOTE
> > depends on BT_HIDP
> > depends on LEDS_CLASS
> > select POWER_SUPPLY
> > + select INPUT_FF_MEMLESS
> > ---help---
> > Support for the Nintendo Wii Remote bluetooth device.
> >
>
> This fix is already in Jiri's tree. See here:
> http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=commitdiff;h=ef6f41157f3864d9bf42671b2ed66062dcafb72e
>
> Regards
> David
I wasn't aware of that. Shouldn't it be pushed to the main tree, then?
It's not in 3.2-rc7 (released yesterday), which is why I reported it.
Thanks,
Alec
next prev parent reply other threads:[~2011-12-25 16:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-24 16:42 [PATCH 1/1] hid_wiimote: add INPUT_FF_MEMLESS dependency Alec Moskvin
2011-12-25 10:06 ` David Herrmann
2011-12-25 10:06 ` David Herrmann
2011-12-25 16:13 ` Alec Moskvin [this message]
2011-12-25 16:13 ` Alec Moskvin
2011-12-26 10:04 ` David Herrmann
2011-12-26 10:04 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111225161320.GA12841@thinkpad \
--to=alecmn@gmail.com \
--cc=dh.herrmann@googlemail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.