All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
To: KAMEZAWA Hiroyuki
	<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/6] memcg: fix broken boolen expression
Date: Mon, 26 Dec 2011 08:57:24 +0200	[thread overview]
Message-ID: <20111226065724.GA13459@shutemov.name> (raw)
In-Reply-To: <20111226153138.0376bd66.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>

On Mon, Dec 26, 2011 at 03:31:38PM +0900, KAMEZAWA Hiroyuki wrote:
> On Sat, 24 Dec 2011 05:00:18 +0200
> "Kirill A. Shutemov" <kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org> wrote:
> 
> > From: "Kirill A. Shutemov" <kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
> > 
> > action != CPU_DEAD || action != CPU_DEAD_FROZEN is always true.
> > 
> > Signed-off-by: Kirill A. Shutemov <kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
> 
> maybe this should go stable..

CC stable@

> 
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
> 
> 
> > ---
> >  mm/memcontrol.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > index b27ce0f..3833a7b 100644
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -2100,7 +2100,7 @@ static int __cpuinit memcg_cpu_hotplug_callback(struct notifier_block *nb,
> >  		return NOTIFY_OK;
> >  	}
> >  
> > -	if ((action != CPU_DEAD) || action != CPU_DEAD_FROZEN)
> > +	if (action != CPU_DEAD && action != CPU_DEAD_FROZEN)
> >  		return NOTIFY_OK;
> >  
> >  	for_each_mem_cgroup(iter)
> > -- 
> > 1.7.7.3
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe cgroups" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
 Kirill A. Shutemov

WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	containers@lists.linux-foundation.org,
	Balbir Singh <bsingharora@gmail.com>,
	Michal Hocko <mhocko@suse.cz>,
	Johannes Weiner <hannes@cmpxchg.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH 5/6] memcg: fix broken boolen expression
Date: Mon, 26 Dec 2011 08:57:24 +0200	[thread overview]
Message-ID: <20111226065724.GA13459@shutemov.name> (raw)
In-Reply-To: <20111226153138.0376bd66.kamezawa.hiroyu@jp.fujitsu.com>

On Mon, Dec 26, 2011 at 03:31:38PM +0900, KAMEZAWA Hiroyuki wrote:
> On Sat, 24 Dec 2011 05:00:18 +0200
> "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
> 
> > From: "Kirill A. Shutemov" <kirill@shutemov.name>
> > 
> > action != CPU_DEAD || action != CPU_DEAD_FROZEN is always true.
> > 
> > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> 
> maybe this should go stable..

CC stable@

> 
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> 
> 
> > ---
> >  mm/memcontrol.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > index b27ce0f..3833a7b 100644
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -2100,7 +2100,7 @@ static int __cpuinit memcg_cpu_hotplug_callback(struct notifier_block *nb,
> >  		return NOTIFY_OK;
> >  	}
> >  
> > -	if ((action != CPU_DEAD) || action != CPU_DEAD_FROZEN)
> > +	if (action != CPU_DEAD && action != CPU_DEAD_FROZEN)
> >  		return NOTIFY_OK;
> >  
> >  	for_each_mem_cgroup(iter)
> > -- 
> > 1.7.7.3
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe cgroups" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
 Kirill A. Shutemov

WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	containers@lists.linux-foundation.org,
	Balbir Singh <bsingharora@gmail.com>,
	Michal Hocko <mhocko@suse.cz>,
	Johannes Weiner <hannes@cmpxchg.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH 5/6] memcg: fix broken boolen expression
Date: Mon, 26 Dec 2011 08:57:24 +0200	[thread overview]
Message-ID: <20111226065724.GA13459@shutemov.name> (raw)
In-Reply-To: <20111226153138.0376bd66.kamezawa.hiroyu@jp.fujitsu.com>

On Mon, Dec 26, 2011 at 03:31:38PM +0900, KAMEZAWA Hiroyuki wrote:
> On Sat, 24 Dec 2011 05:00:18 +0200
> "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
> 
> > From: "Kirill A. Shutemov" <kirill@shutemov.name>
> > 
> > action != CPU_DEAD || action != CPU_DEAD_FROZEN is always true.
> > 
> > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> 
> maybe this should go stable..

CC stable@

> 
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> 
> 
> > ---
> >  mm/memcontrol.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > index b27ce0f..3833a7b 100644
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -2100,7 +2100,7 @@ static int __cpuinit memcg_cpu_hotplug_callback(struct notifier_block *nb,
> >  		return NOTIFY_OK;
> >  	}
> >  
> > -	if ((action != CPU_DEAD) || action != CPU_DEAD_FROZEN)
> > +	if (action != CPU_DEAD && action != CPU_DEAD_FROZEN)
> >  		return NOTIFY_OK;
> >  
> >  	for_each_mem_cgroup(iter)
> > -- 
> > 1.7.7.3
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe cgroups" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2011-12-26  6:57 UTC|newest]

Thread overview: 116+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-24  3:00 [PATCH 1/6] memcg: fix unused variable warning Kirill A. Shutemov
2011-12-24  3:00 ` Kirill A. Shutemov
2011-12-24  3:00 ` Kirill A. Shutemov
2011-12-24  3:00 ` [PATCH 2/6] memcg: mark more functions/variables as static Kirill A. Shutemov
2011-12-24  3:00   ` Kirill A. Shutemov
     [not found]   ` <1324695619-5537-2-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-26  6:28     ` KAMEZAWA Hiroyuki
2011-12-26  6:28       ` KAMEZAWA Hiroyuki
2011-12-26  6:28       ` KAMEZAWA Hiroyuki
2011-12-26  6:28     ` KAMEZAWA Hiroyuki
2011-12-27 14:05     ` Michal Hocko
2011-12-27 14:05       ` Michal Hocko
2011-12-27 14:05       ` Michal Hocko
2011-12-27 14:05     ` Michal Hocko
2011-12-24  3:00 ` [PATCH 3/6] memcg: remove unused variable Kirill A. Shutemov
2011-12-24  3:00   ` Kirill A. Shutemov
2011-12-24  3:00   ` Kirill A. Shutemov
2011-12-26  6:29   ` KAMEZAWA Hiroyuki
2011-12-26  6:29     ` KAMEZAWA Hiroyuki
     [not found]   ` <1324695619-5537-3-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-26  6:29     ` KAMEZAWA Hiroyuki
2011-12-27 14:08     ` Michal Hocko
2011-12-27 14:08     ` Michal Hocko
2011-12-27 14:08       ` Michal Hocko
2011-12-27 14:08       ` Michal Hocko
2011-12-24  3:00 ` [PATCH 4/6] memcg: mark stat field of mem_cgroup struct as __percpu Kirill A. Shutemov
2011-12-24  3:00   ` Kirill A. Shutemov
     [not found]   ` <1324695619-5537-4-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-26  6:30     ` KAMEZAWA Hiroyuki
2011-12-26  6:30       ` KAMEZAWA Hiroyuki
2011-12-26  6:30       ` KAMEZAWA Hiroyuki
2011-12-26  6:30     ` KAMEZAWA Hiroyuki
2011-12-27 14:11     ` Michal Hocko
2011-12-27 14:11       ` Michal Hocko
2011-12-27 14:11       ` Michal Hocko
2011-12-27 14:11     ` Michal Hocko
2011-12-24  3:00 ` [PATCH 5/6] memcg: fix broken boolen expression Kirill A. Shutemov
2011-12-24  3:00   ` Kirill A. Shutemov
     [not found]   ` <1324695619-5537-5-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-26  6:31     ` KAMEZAWA Hiroyuki
2011-12-26  6:31       ` KAMEZAWA Hiroyuki
2011-12-26  6:31       ` KAMEZAWA Hiroyuki
     [not found]       ` <20111226153138.0376bd66.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2011-12-26  6:57         ` Kirill A. Shutemov [this message]
2011-12-26  6:57           ` Kirill A. Shutemov
2011-12-26  6:57           ` Kirill A. Shutemov
     [not found]           ` <20111226065724.GA13459-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2012-01-03 20:54             ` Greg KH
2012-01-03 20:54               ` Greg KH
2012-01-03 20:54               ` Greg KH
2011-12-26  6:31     ` KAMEZAWA Hiroyuki
2011-12-27 14:17     ` Michal Hocko
2011-12-27 14:17       ` Michal Hocko
2011-12-27 14:17       ` Michal Hocko
2012-04-04 21:34     ` Andrew Morton
2012-04-04 21:34       ` Andrew Morton
2012-04-04 21:34       ` Andrew Morton
     [not found]       ` <20120404143403.fd05a284.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-04-05 10:17         ` Kirill A. Shutemov
2012-04-05 10:17         ` Kirill A. Shutemov
2012-04-05 10:17           ` Kirill A. Shutemov
2012-04-05 10:17           ` Kirill A. Shutemov
     [not found] ` <1324695619-5537-1-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-24  3:00   ` [PATCH 2/6] memcg: mark more functions/variables as static Kirill A. Shutemov
2011-12-24  3:00   ` [PATCH 3/6] memcg: remove unused variable Kirill A. Shutemov
2011-12-24  3:00   ` [PATCH 4/6] memcg: mark stat field of mem_cgroup struct as __percpu Kirill A. Shutemov
2011-12-24  3:00   ` [PATCH 5/6] memcg: fix broken boolen expression Kirill A. Shutemov
2011-12-24  3:00   ` [PATCH 6/6] memcg: drop redundant brackets Kirill A. Shutemov
2011-12-26  6:25   ` [PATCH 1/6] memcg: fix unused variable warning KAMEZAWA Hiroyuki
2011-12-27 13:57   ` [PATCH] Makefiles: Disable unused-variable warning (was: Re: [PATCH 1/6] memcg: fix unused variable warning) Michal Hocko
2011-12-24  3:00 ` [PATCH 6/6] memcg: drop redundant brackets Kirill A. Shutemov
2011-12-24  3:00   ` Kirill A. Shutemov
     [not found]   ` <1324695619-5537-6-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-26  6:40     ` KAMEZAWA Hiroyuki
2011-12-27 14:28     ` Michal Hocko
2011-12-26  6:40   ` KAMEZAWA Hiroyuki
2011-12-26  6:40     ` KAMEZAWA Hiroyuki
2011-12-27 14:28   ` Michal Hocko
2011-12-27 14:28     ` Michal Hocko
2011-12-26  6:25 ` [PATCH 1/6] memcg: fix unused variable warning KAMEZAWA Hiroyuki
2011-12-26  6:25   ` KAMEZAWA Hiroyuki
     [not found]   ` <20111226152531.e0335ec4.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2011-12-26  6:36     ` Kirill A. Shutemov
2011-12-26  6:36     ` Kirill A. Shutemov
2011-12-26  6:36       ` Kirill A. Shutemov
2011-12-26  6:36       ` Kirill A. Shutemov
     [not found]       ` <20111226063652.GA13273-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-26  6:42         ` KAMEZAWA Hiroyuki
2011-12-26  6:42           ` KAMEZAWA Hiroyuki
2011-12-26  6:42           ` KAMEZAWA Hiroyuki
     [not found]           ` <20111226154252.d3621532.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2011-12-26  6:47             ` Kirill A. Shutemov
2011-12-26  6:47             ` Kirill A. Shutemov
2011-12-26  6:47               ` Kirill A. Shutemov
2011-12-26  6:47               ` Kirill A. Shutemov
     [not found]               ` <20111226064734.GA13355-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-26  6:50                 ` KAMEZAWA Hiroyuki
2011-12-26  6:50                   ` KAMEZAWA Hiroyuki
2011-12-26  6:50                   ` KAMEZAWA Hiroyuki
2011-12-26  6:50                 ` KAMEZAWA Hiroyuki
2011-12-26  6:42         ` KAMEZAWA Hiroyuki
2011-12-27 13:57 ` [PATCH] Makefiles: Disable unused-variable warning (was: Re: [PATCH 1/6] memcg: fix unused variable warning) Michal Hocko
2011-12-27 13:57   ` Michal Hocko
2011-12-27 13:57   ` Michal Hocko
2011-12-27 13:57   ` Michal Hocko
2011-12-27 18:26   ` Kirill A. Shutemov
2011-12-27 18:26     ` Kirill A. Shutemov
2011-12-27 18:26     ` Kirill A. Shutemov
2011-12-27 18:26     ` Kirill A. Shutemov
     [not found]     ` <20111227182613.GA21840-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-29 10:42       ` Michal Hocko
2011-12-29 10:42         ` Michal Hocko
2011-12-29 10:42         ` Michal Hocko
2011-12-29 11:08         ` Kirill A. Shutemov
2011-12-29 11:08           ` Kirill A. Shutemov
2011-12-29 11:08           ` Kirill A. Shutemov
     [not found]           ` <20111229110850.GA5680-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-29 11:16             ` Michal Hocko
2011-12-29 11:16               ` Michal Hocko
2011-12-29 11:16               ` Michal Hocko
2011-12-29 11:16             ` Michal Hocko
     [not found]         ` <20111229104230.GA20854-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2011-12-29 11:08           ` Kirill A. Shutemov
2011-12-29 10:42       ` Michal Hocko
     [not found]   ` <20111227135752.GK5344-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2011-12-27 18:26     ` Kirill A. Shutemov
2012-01-08 15:01     ` [PATCH] Makefiles: Disable unused-variable warning Michal Marek
2012-01-08 15:01     ` Michal Marek
2012-01-08 15:01       ` Michal Marek
2012-01-08 15:01       ` Michal Marek
     [not found]       ` <4F09AFBD.60503-AlSwsSmVLrQ@public.gmane.org>
2012-01-10  8:52         ` Michal Hocko
2012-01-10  8:52       ` Michal Hocko
2012-01-10  8:52         ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111226065724.GA13459@shutemov.name \
    --to=kirill-okw7cidhh8elwutg50ltga@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
    --cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.