* [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page
@ 2011-12-23 13:38 ` Hillf Danton
0 siblings, 0 replies; 8+ messages in thread
From: Hillf Danton @ 2011-12-23 13:38 UTC (permalink / raw)
To: linux-mm; +Cc: LKML, Andrew Morton, Michal Hocko, KAMEZAWA Hiroyuki
From: Hillf Danton <dhillf@gmail.com>
Subject: [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page
If we have to hand back the newly allocated huge page to page allocator,
for any reason, the changed counter should be recovered.
Cc: Michal Hocko <mhocko@suse.cz>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Hillf Danton <dhillf@gmail.com>
---
--- a/mm/hugetlb.c Tue Dec 20 21:26:30 2011
+++ b/mm/hugetlb.c Fri Dec 23 21:18:06 2011
@@ -800,7 +800,7 @@ static struct page *alloc_buddy_huge_pag
if (page && arch_prepare_hugepage(page)) {
__free_pages(page, huge_page_order(h));
- return NULL;
+ page = NULL;
}
spin_lock(&hugetlb_lock);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page
@ 2011-12-23 13:38 ` Hillf Danton
0 siblings, 0 replies; 8+ messages in thread
From: Hillf Danton @ 2011-12-23 13:38 UTC (permalink / raw)
To: linux-mm; +Cc: LKML, Andrew Morton, Michal Hocko, KAMEZAWA Hiroyuki
From: Hillf Danton <dhillf@gmail.com>
Subject: [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page
If we have to hand back the newly allocated huge page to page allocator,
for any reason, the changed counter should be recovered.
Cc: Michal Hocko <mhocko@suse.cz>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Hillf Danton <dhillf@gmail.com>
---
--- a/mm/hugetlb.c Tue Dec 20 21:26:30 2011
+++ b/mm/hugetlb.c Fri Dec 23 21:18:06 2011
@@ -800,7 +800,7 @@ static struct page *alloc_buddy_huge_pag
if (page && arch_prepare_hugepage(page)) {
__free_pages(page, huge_page_order(h));
- return NULL;
+ page = NULL;
}
spin_lock(&hugetlb_lock);
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page
2011-12-23 13:38 ` Hillf Danton
@ 2011-12-26 7:28 ` KAMEZAWA Hiroyuki
-1 siblings, 0 replies; 8+ messages in thread
From: KAMEZAWA Hiroyuki @ 2011-12-26 7:28 UTC (permalink / raw)
To: Hillf Danton; +Cc: linux-mm, LKML, Andrew Morton, Michal Hocko
On Fri, 23 Dec 2011 21:38:38 +0800
Hillf Danton <dhillf@gmail.com> wrote:
> From: Hillf Danton <dhillf@gmail.com>
> Subject: [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page
>
> If we have to hand back the newly allocated huge page to page allocator,
> for any reason, the changed counter should be recovered.
>
> Cc: Michal Hocko <mhocko@suse.cz>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page
@ 2011-12-26 7:28 ` KAMEZAWA Hiroyuki
0 siblings, 0 replies; 8+ messages in thread
From: KAMEZAWA Hiroyuki @ 2011-12-26 7:28 UTC (permalink / raw)
To: Hillf Danton; +Cc: linux-mm, LKML, Andrew Morton, Michal Hocko
On Fri, 23 Dec 2011 21:38:38 +0800
Hillf Danton <dhillf@gmail.com> wrote:
> From: Hillf Danton <dhillf@gmail.com>
> Subject: [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page
>
> If we have to hand back the newly allocated huge page to page allocator,
> for any reason, the changed counter should be recovered.
>
> Cc: Michal Hocko <mhocko@suse.cz>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page
2011-12-23 13:38 ` Hillf Danton
@ 2011-12-27 12:57 ` Michal Hocko
-1 siblings, 0 replies; 8+ messages in thread
From: Michal Hocko @ 2011-12-27 12:57 UTC (permalink / raw)
To: Hillf Danton; +Cc: linux-mm, LKML, Andrew Morton, KAMEZAWA Hiroyuki
On Fri 23-12-11 21:38:38, Hillf Danton wrote:
> From: Hillf Danton <dhillf@gmail.com>
> Subject: [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page
>
> If we have to hand back the newly allocated huge page to page allocator,
> for any reason, the changed counter should be recovered.
>
> Cc: Michal Hocko <mhocko@suse.cz>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
Broken since 2.6.27 (caff3a2c: hugetlb: call arch_prepare_hugepage() for
surplus pages) so a stable material
Reviewed-by: Michal Hocko <mhocko@suse.cz>
Thanks
> ---
>
> --- a/mm/hugetlb.c Tue Dec 20 21:26:30 2011
> +++ b/mm/hugetlb.c Fri Dec 23 21:18:06 2011
> @@ -800,7 +800,7 @@ static struct page *alloc_buddy_huge_pag
>
> if (page && arch_prepare_hugepage(page)) {
> __free_pages(page, huge_page_order(h));
> - return NULL;
> + page = NULL;
> }
>
> spin_lock(&hugetlb_lock);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page
@ 2011-12-27 12:57 ` Michal Hocko
0 siblings, 0 replies; 8+ messages in thread
From: Michal Hocko @ 2011-12-27 12:57 UTC (permalink / raw)
To: Hillf Danton; +Cc: linux-mm, LKML, Andrew Morton, KAMEZAWA Hiroyuki
On Fri 23-12-11 21:38:38, Hillf Danton wrote:
> From: Hillf Danton <dhillf@gmail.com>
> Subject: [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page
>
> If we have to hand back the newly allocated huge page to page allocator,
> for any reason, the changed counter should be recovered.
>
> Cc: Michal Hocko <mhocko@suse.cz>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
Broken since 2.6.27 (caff3a2c: hugetlb: call arch_prepare_hugepage() for
surplus pages) so a stable material
Reviewed-by: Michal Hocko <mhocko@suse.cz>
Thanks
> ---
>
> --- a/mm/hugetlb.c Tue Dec 20 21:26:30 2011
> +++ b/mm/hugetlb.c Fri Dec 23 21:18:06 2011
> @@ -800,7 +800,7 @@ static struct page *alloc_buddy_huge_pag
>
> if (page && arch_prepare_hugepage(page)) {
> __free_pages(page, huge_page_order(h));
> - return NULL;
> + page = NULL;
> }
>
> spin_lock(&hugetlb_lock);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page
2011-12-27 12:57 ` Michal Hocko
@ 2011-12-27 23:51 ` Andrew Morton
-1 siblings, 0 replies; 8+ messages in thread
From: Andrew Morton @ 2011-12-27 23:51 UTC (permalink / raw)
To: Michal Hocko
Cc: Hillf Danton, linux-mm, LKML, KAMEZAWA Hiroyuki,
Martin Schwidefsky, Heiko Carstens
On Tue, 27 Dec 2011 13:57:01 +0100
Michal Hocko <mhocko@suse.cz> wrote:
> On Fri 23-12-11 21:38:38, Hillf Danton wrote:
> > From: Hillf Danton <dhillf@gmail.com>
> > Subject: [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page
> >
> > If we have to hand back the newly allocated huge page to page allocator,
> > for any reason, the changed counter should be recovered.
> >
> > Cc: Michal Hocko <mhocko@suse.cz>
> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Hillf Danton <dhillf@gmail.com>
>
> Broken since 2.6.27 (caff3a2c: hugetlb: call arch_prepare_hugepage() for
> surplus pages) so a stable material
afacit only s390 is affected, and s390's page_table_alloc() is fairly
immortal, using GFP_KERNEL|__GFP_REPEAT.
So unless Martin and Heiko disagree, I think we can merge this in 3.3-rc1.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page
@ 2011-12-27 23:51 ` Andrew Morton
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Morton @ 2011-12-27 23:51 UTC (permalink / raw)
To: Michal Hocko
Cc: Hillf Danton, linux-mm, LKML, KAMEZAWA Hiroyuki,
Martin Schwidefsky, Heiko Carstens
On Tue, 27 Dec 2011 13:57:01 +0100
Michal Hocko <mhocko@suse.cz> wrote:
> On Fri 23-12-11 21:38:38, Hillf Danton wrote:
> > From: Hillf Danton <dhillf@gmail.com>
> > Subject: [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page
> >
> > If we have to hand back the newly allocated huge page to page allocator,
> > for any reason, the changed counter should be recovered.
> >
> > Cc: Michal Hocko <mhocko@suse.cz>
> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Hillf Danton <dhillf@gmail.com>
>
> Broken since 2.6.27 (caff3a2c: hugetlb: call arch_prepare_hugepage() for
> surplus pages) so a stable material
afacit only s390 is affected, and s390's page_table_alloc() is fairly
immortal, using GFP_KERNEL|__GFP_REPEAT.
So unless Martin and Heiko disagree, I think we can merge this in 3.3-rc1.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-12-27 23:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-23 13:38 [PATCH] mm: hugetlb: avoid bogus counter of surplus huge page Hillf Danton
2011-12-23 13:38 ` Hillf Danton
2011-12-26 7:28 ` KAMEZAWA Hiroyuki
2011-12-26 7:28 ` KAMEZAWA Hiroyuki
2011-12-27 12:57 ` Michal Hocko
2011-12-27 12:57 ` Michal Hocko
2011-12-27 23:51 ` Andrew Morton
2011-12-27 23:51 ` Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.