All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty
Date: Thu, 29 Dec 2011 18:57:56 +0530	[thread overview]
Message-ID: <20111229132756.GB4576@amit.redhat.com> (raw)
In-Reply-To: <4EFC616F.4060806@de.ibm.com>

On (Thu) 29 Dec 2011 [13:47:43], Christian Borntraeger wrote:
> From: Christian Borntraeger <borntraeger@de.ibm.com>
>     
> when I tried qemu with -virtio-console pty the guest hangs and attaching on /dev/pts/<x> does
> not return anything if the attachement is too late.
> Turns out that the console is already throttled and the guest is heavily spinning but get_buf
> never returns the buffer. There seems to be no way for the console to unthrottle the port.

It doesn't really get throttled, since the throttling
enabling/disabling isn't yet done in QEMU.  What happens is that the
chardev buffer gets filled up and qemu_chr_fe_write() doesn't return
-- send_all() keeps spinning.

I'll adjust the commit log message and submit.

Thanks.

		Amit

  reply	other threads:[~2011-12-29 13:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-15 12:44 [Qemu-devel] [RFC] virtio-console fails on unconnected pty Christian Borntraeger
2011-12-16  9:23 ` Amit Shah
2011-12-29 12:47 ` [Qemu-devel] [PATCHv2] Fix virtio-console failure " Christian Borntraeger
2011-12-29 13:27   ` Amit Shah [this message]
2011-12-29 13:39     ` Andreas Färber
2011-12-29 14:04   ` Amit Shah
2011-12-29 14:16     ` Christian Borntraeger
2011-12-29 14:19       ` Christian Borntraeger
2011-12-29 14:26       ` Amit Shah
2011-12-29 14:32         ` Christian Borntraeger
2011-12-29 14:56           ` Amit Shah
2011-12-29 15:14             ` Christian Borntraeger
2011-12-29 15:14           ` Amit Shah
2012-01-02 15:34             ` Alexander Graf
2012-01-02 15:41               ` Christian Borntraeger
2012-01-02 16:55                 ` Alexander Graf
2012-01-03 15:49                   ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111229132756.GB4576@amit.redhat.com \
    --to=amit.shah@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.