Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty

[Christian Borntraeger <borntraeger@de.ibm.com>]

On 02/01/12 16:34, Alexander Graf wrote:
>>>            if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
>>>                virtio_serial_throttle_port(port, true);
>>
>> Ah; I see what's happening.  pty_chr_write() returns 0 if a client
>> isn't yet connected.
>>
>> This is different from the buggy tcp_chr_write() code, which just
>> returns 'len', i.e. a successful write.  And since I've only tested
>> with tcp/unix sockets, I couldn't see why throttling could get
>> enabled.
> 
> So what's the conclusion then? :)

My conclusion is that with my patch virtio-console on a pty works, without
it doesnt. :-) 
I think Amit said that he is going to apply the patch.

Christian