* [PATCH] Fix wiimote device_get_address to use new API
@ 2011-12-29 16:59 David Herrmann
2011-12-29 17:15 ` Anderson Lizardo
2011-12-30 11:06 ` Johan Hedberg
0 siblings, 2 replies; 7+ messages in thread
From: David Herrmann @ 2011-12-29 16:59 UTC (permalink / raw)
To: linux-bluetooth; +Cc: johan.hedberg, David Herrmann
Commit b06899eace1f484b387aae0e568fb1da988b468c introduced a new API for
device_get_name but apparently missed fixing the call in plugins/wiimote.c. This
patch converts the plugin to use the new API.
---
plugins/wiimote.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/plugins/wiimote.c b/plugins/wiimote.c
index fead72a..1ae638b 100644
--- a/plugins/wiimote.c
+++ b/plugins/wiimote.c
@@ -63,7 +63,7 @@ static ssize_t wii_pincb(struct btd_adapter *adapter, struct btd_device *device,
char addr[18];
adapter_get_address(adapter, &sba);
- device_get_address(device, &dba);
+ device_get_address(device, &dba, NULL);
ba2str(&dba, addr);
vendor = btd_device_get_vendor(device);
--
1.7.8.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix wiimote device_get_address to use new API
2011-12-29 16:59 [PATCH] Fix wiimote device_get_address to use new API David Herrmann
@ 2011-12-29 17:15 ` Anderson Lizardo
2011-12-29 17:19 ` [PATCH] Add wiimote plugin to bootstrap-configure David Herrmann
2011-12-29 17:20 ` [PATCH] Fix wiimote device_get_address to use new API David Herrmann
2011-12-30 11:06 ` Johan Hedberg
1 sibling, 2 replies; 7+ messages in thread
From: Anderson Lizardo @ 2011-12-29 17:15 UTC (permalink / raw)
To: David Herrmann; +Cc: linux-bluetooth, johan.hedberg
Hi David,
On Thu, Dec 29, 2011 at 12:59 PM, David Herrmann
<dh.herrmann@googlemail.com> wrote:
> Commit b06899eace1f484b387aae0e568fb1da988b468c introduced a new API for
> device_get_name but apparently missed fixing the call in plugins/wiimote.c. This
> patch converts the plugin to use the new API.
You should consider adding this plugin to bootstrap-configure, so it
is not forgotten again. Currently it is not built by running
"./bootstrap-configure"
Regards,
--
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Add wiimote plugin to bootstrap-configure
2011-12-29 17:15 ` Anderson Lizardo
@ 2011-12-29 17:19 ` David Herrmann
2011-12-29 17:22 ` [PATCH v2] " David Herrmann
2011-12-29 17:20 ` [PATCH] Fix wiimote device_get_address to use new API David Herrmann
1 sibling, 1 reply; 7+ messages in thread
From: David Herrmann @ 2011-12-29 17:19 UTC (permalink / raw)
To: linux-bluetooth; +Cc: anderson.lizardo, johan.hedberg, David Herrmann
Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
---
bootstrap-configure | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/bootstrap-configure b/bootstrap-configure
index 94da969..89ea156 100755
--- a/bootstrap-configure
+++ b/bootstrap-configure
@@ -34,5 +34,6 @@ fi
--enable-cups \
--enable-sap \
--enable-thermometer \
+ --enable-wiimote \
--disable-pcmcia \
--disable-datafiles $*
--
1.7.8.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix wiimote device_get_address to use new API
2011-12-29 17:15 ` Anderson Lizardo
2011-12-29 17:19 ` [PATCH] Add wiimote plugin to bootstrap-configure David Herrmann
@ 2011-12-29 17:20 ` David Herrmann
1 sibling, 0 replies; 7+ messages in thread
From: David Herrmann @ 2011-12-29 17:20 UTC (permalink / raw)
To: Anderson Lizardo; +Cc: linux-bluetooth, johan.hedberg
On Thu, Dec 29, 2011 at 6:15 PM, Anderson Lizardo
<anderson.lizardo@openbossa.org> wrote:
> Hi David,
>
> On Thu, Dec 29, 2011 at 12:59 PM, David Herrmann
> <dh.herrmann@googlemail.com> wrote:
>> Commit b06899eace1f484b387aae0e568fb1da988b468c introduced a new API for
>> device_get_name but apparently missed fixing the call in plugins/wiimote.c. This
>> patch converts the plugin to use the new API.
>
> You should consider adding this plugin to bootstrap-configure, so it
> is not forgotten again. Currently it is not built by running
> "./bootstrap-configure"
Ah, I didn't know of it. I've sent a separate patch. Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix wiimote device_get_address to use new API
2011-12-29 16:59 [PATCH] Fix wiimote device_get_address to use new API David Herrmann
2011-12-29 17:15 ` Anderson Lizardo
@ 2011-12-30 11:06 ` Johan Hedberg
1 sibling, 0 replies; 7+ messages in thread
From: Johan Hedberg @ 2011-12-30 11:06 UTC (permalink / raw)
To: David Herrmann; +Cc: linux-bluetooth
Hi David,
On Thu, Dec 29, 2011, David Herrmann wrote:
> Commit b06899eace1f484b387aae0e568fb1da988b468c introduced a new API
> for device_get_name but apparently missed fixing the call in
> plugins/wiimote.c. This patch converts the plugin to use the new API.
> ---
> plugins/wiimote.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied after the obvious s/get_name/get_address/ in the commit message.
Thanks.
Johan
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-12-30 11:06 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-29 16:59 [PATCH] Fix wiimote device_get_address to use new API David Herrmann
2011-12-29 17:15 ` Anderson Lizardo
2011-12-29 17:19 ` [PATCH] Add wiimote plugin to bootstrap-configure David Herrmann
2011-12-29 17:22 ` [PATCH v2] " David Herrmann
2011-12-30 11:06 ` Johan Hedberg
2011-12-29 17:20 ` [PATCH] Fix wiimote device_get_address to use new API David Herrmann
2011-12-30 11:06 ` Johan Hedberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.