From: "Heiko Stübner" <heiko@sntech.de>
To: Dron Gus <dron0gus@gmail.com>
Cc: davej@redhat.com, Kukjin Kim <kgene.kim@samsung.com>,
cpufreq@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [RFC] cpufreq: Add S3C2416/S3C2450 cpufreq driver
Date: Fri, 30 Dec 2011 13:07:42 +0100 [thread overview]
Message-ID: <201112301307.43109.heiko@sntech.de> (raw)
In-Reply-To: <CAA11ShBk=HFt6qaZex+VK=DfZtTvrf9bhyLKW0Gk2g_E5D44PA@mail.gmail.com>
Am Freitag 30 Dezember 2011, 08:48:30 schrieb Dron Gus:
> Hi.
>
> On Thu, Dec 29, 2011 at 11:58 PM, Heiko Stübner <heiko@sntech.de> wrote:
> ...
>
> > +static int __init s3c2416_cpufreq_driver_init(struct cpufreq_policy
> > *policy)
>
> ...
>
> > + s3c_freq->armdiv = clk_get(NULL, "armdiv");
> > + if (IS_ERR(s3c_freq->armdiv)) {
> > + pr_err("cpufreq: Unable to obtain ARMDIV: %ld\n",
> > + PTR_ERR(s3c_freq->armdiv));
> > + return PTR_ERR(s3c_freq->armdiv);
> > + }
> > +
> > + s3c_freq->hclk = clk_get(NULL, "hclk");
> > + if (IS_ERR(s3c_freq->hclk)) {
> > + pr_warn("cpufreq: Unable to obtain HCLK: %ld\n",
> > + PTR_ERR(s3c_freq->hclk));
> > + s3c_freq->hclk = NULL; /*we can live without hclk */
> > + }
>
> clk_put allready obtained "armdiv"?
>
> > +
> > + s3c_freq->armclk = clk_get(NULL, "armclk");
> > + if (IS_ERR(s3c_freq->armclk)) {
> > + pr_err("cpufreq: Unable to obtain ARMCLK: %ld\n",
> > + PTR_ERR(s3c_freq->armclk));
> > + return PTR_ERR(s3c_freq->armclk);
> > + }
>
> Same for "hclk" and "armclk"?
thanks for finding those, it seems probe also needs a lot more love.
As you were also working on S3C2416 stuff, could you possibly test the driver
and see if it still hangs for you?
After I introduced the switch from hclk to armdiv using a forced armdiv=hclk
frequency the hangs stopped for me and the devices ran hours with varying
workloads without hangs. (also including voltage scaling)
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] cpufreq: Add S3C2416/S3C2450 cpufreq driver
Date: Fri, 30 Dec 2011 13:07:42 +0100 [thread overview]
Message-ID: <201112301307.43109.heiko@sntech.de> (raw)
In-Reply-To: <CAA11ShBk=HFt6qaZex+VK=DfZtTvrf9bhyLKW0Gk2g_E5D44PA@mail.gmail.com>
Am Freitag 30 Dezember 2011, 08:48:30 schrieb Dron Gus:
> Hi.
>
> On Thu, Dec 29, 2011 at 11:58 PM, Heiko St?bner <heiko@sntech.de> wrote:
> ...
>
> > +static int __init s3c2416_cpufreq_driver_init(struct cpufreq_policy
> > *policy)
>
> ...
>
> > + s3c_freq->armdiv = clk_get(NULL, "armdiv");
> > + if (IS_ERR(s3c_freq->armdiv)) {
> > + pr_err("cpufreq: Unable to obtain ARMDIV: %ld\n",
> > + PTR_ERR(s3c_freq->armdiv));
> > + return PTR_ERR(s3c_freq->armdiv);
> > + }
> > +
> > + s3c_freq->hclk = clk_get(NULL, "hclk");
> > + if (IS_ERR(s3c_freq->hclk)) {
> > + pr_warn("cpufreq: Unable to obtain HCLK: %ld\n",
> > + PTR_ERR(s3c_freq->hclk));
> > + s3c_freq->hclk = NULL; /*we can live without hclk */
> > + }
>
> clk_put allready obtained "armdiv"?
>
> > +
> > + s3c_freq->armclk = clk_get(NULL, "armclk");
> > + if (IS_ERR(s3c_freq->armclk)) {
> > + pr_err("cpufreq: Unable to obtain ARMCLK: %ld\n",
> > + PTR_ERR(s3c_freq->armclk));
> > + return PTR_ERR(s3c_freq->armclk);
> > + }
>
> Same for "hclk" and "armclk"?
thanks for finding those, it seems probe also needs a lot more love.
As you were also working on S3C2416 stuff, could you possibly test the driver
and see if it still hangs for you?
After I introduced the switch from hclk to armdiv using a forced armdiv=hclk
frequency the hangs stopped for me and the devices ran hours with varying
workloads without hangs. (also including voltage scaling)
Heiko
next prev parent reply other threads:[~2011-12-30 12:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 19:58 [RFC] cpufreq: Add S3C2416/S3C2450 cpufreq driver Heiko Stübner
2011-12-29 19:58 ` Heiko Stübner
2011-12-30 7:48 ` Dron Gus
2011-12-30 7:48 ` Dron Gus
2011-12-30 12:07 ` Heiko Stübner [this message]
2011-12-30 12:07 ` Heiko Stübner
2011-12-30 8:23 ` Richard Zhao
2011-12-30 8:23 ` Richard Zhao
2011-12-30 12:00 ` Heiko Stübner
2011-12-30 12:00 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112301307.43109.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=dron0gus@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.