From: Ted Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: Yongqiang Yang <xiaoqiangnk@gmail.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 4/5] ext4: flush journal when switching from journal data mode
Date: Fri, 30 Dec 2011 09:57:56 -0500 [thread overview]
Message-ID: <20111230145756.GB29547@thunk.org> (raw)
In-Reply-To: <20111229210153.GN8233@tux1.beaverton.ibm.com>
On Thu, Dec 29, 2011 at 01:01:53PM -0800, Darrick J. Wong wrote:
> > It's necessary to flush the journal when switching away from
> > data=journal mode. This is because there are no revoke records when
> > we are data blocks are journalled,
>
> Minor nit, but did you mean "when data blocks are journalled" ?
Thanks, I've made this fix in commit description.
- Ted
next prev parent reply other threads:[~2011-12-30 14:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 8:07 [PATCH 1/5] ext4: allocate delalloc blocks before changing journal mode Yongqiang Yang
2011-11-15 8:07 ` [PATCH 2/5] ext4: let ext4 journal deletion of data blocks Yongqiang Yang
2011-12-28 17:23 ` Ted Ts'o
2011-12-30 14:59 ` Yongqiang Yang
2011-12-30 15:05 ` Ted Ts'o
2011-11-15 8:07 ` [PATCH 3/5] ext4: let ext4_free_blocks handle multiblock correctly Yongqiang Yang
2011-12-28 17:23 ` Ted Ts'o
2011-11-15 8:07 ` [PATCH 4/5] ext4: flush journal when switching from journal data mode Yongqiang Yang
2011-12-28 18:56 ` Ted Ts'o
2011-12-29 21:01 ` Darrick J. Wong
2011-12-30 14:43 ` Yongqiang Yang
2011-12-30 14:57 ` Ted Ts'o [this message]
2011-11-15 8:07 ` [PATCH 5/5] jbd2: clear revoked flag on buffers before a new transaction started Yongqiang Yang
2011-12-28 23:25 ` Ted Ts'o
2011-12-09 3:31 ` [PATCH 1/5] ext4: allocate delalloc blocks before changing journal mode Toshiyuki Okajima
2011-12-28 17:14 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111230145756.GB29547@thunk.org \
--to=tytso@mit.edu \
--cc=djwong@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.