From: Ted Ts'o <tytso@mit.edu>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/5] ext4: let ext4 journal deletion of data blocks
Date: Fri, 30 Dec 2011 10:05:57 -0500 [thread overview]
Message-ID: <20111230150557.GC29547@thunk.org> (raw)
In-Reply-To: <CAGBYx2YbJZog0oNvyrvcyyEZ9sDQGaHZGgJyr4DxaZnX9L5fNw@mail.gmail.com>
On Fri, Dec 30, 2011 at 10:59:48PM +0800, Yongqiang Yang wrote:
> Hi Ted,
>
> The 2nd and 3rd patch aim to let ext4_free_blocks work with journal
> mode. Consider that journal mode of a file is changed from ordered
> mode to journal mode and several data blocks are deleted, then bh
> passed in is NULL and sb_find_get_block returns NULL, but we need
> ext4_forget to handle the data blocks to record them in revoke table.
Ah, I see. This wasn't obvious from the commit description. Could
you combine patches #2 and #3, and add the above detail in the commit
description?
Many thanks!!
- Ted
next prev parent reply other threads:[~2011-12-30 15:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 8:07 [PATCH 1/5] ext4: allocate delalloc blocks before changing journal mode Yongqiang Yang
2011-11-15 8:07 ` [PATCH 2/5] ext4: let ext4 journal deletion of data blocks Yongqiang Yang
2011-12-28 17:23 ` Ted Ts'o
2011-12-30 14:59 ` Yongqiang Yang
2011-12-30 15:05 ` Ted Ts'o [this message]
2011-11-15 8:07 ` [PATCH 3/5] ext4: let ext4_free_blocks handle multiblock correctly Yongqiang Yang
2011-12-28 17:23 ` Ted Ts'o
2011-11-15 8:07 ` [PATCH 4/5] ext4: flush journal when switching from journal data mode Yongqiang Yang
2011-12-28 18:56 ` Ted Ts'o
2011-12-29 21:01 ` Darrick J. Wong
2011-12-30 14:43 ` Yongqiang Yang
2011-12-30 14:57 ` Ted Ts'o
2011-11-15 8:07 ` [PATCH 5/5] jbd2: clear revoked flag on buffers before a new transaction started Yongqiang Yang
2011-12-28 23:25 ` Ted Ts'o
2011-12-09 3:31 ` [PATCH 1/5] ext4: allocate delalloc blocks before changing journal mode Toshiyuki Okajima
2011-12-28 17:14 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111230150557.GC29547@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.