From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, rpurdie@rpsys.net,
linux-samsung-soc@vger.kernel.org, grant.likely@secretlab.ca,
rob.herring@calxeda.com, kgene.kim@samsung.com,
jg1.han@samsung.com, kyungmin.park@samsung.com, cbou@mail.ru,
kwangwoo.lee@gmail.com, augulis.darius@gmail.com,
ben-linux@fluff.org, patches@linaro.org
Subject: Re: [RFC][PATCH 2/4] lcd: platform-lcd: Add support for Hydis hv070wsa lcd panel
Date: Mon, 2 Jan 2012 11:45:59 +0000 [thread overview]
Message-ID: <20120102114559.GE2899@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1325483675-21908-3-git-send-email-thomas.abraham@linaro.org>
On Mon, Jan 02, 2012 at 11:24:33AM +0530, Thomas Abraham wrote:
> +static void lcd_hv070wsa_set_power(struct platform_lcd *plcd, unsigned int pwr)
> +{
> + struct plat_lcd_hydis_hv070wsa_pdata *pdata = plcd->lcd_pdata;
> +
> + gpio_direction_output(pdata->gpio, pwr);
> +}
This doesn't look at all specific to this panel - it's just setting a
GPIO - so it should probably just be a generic gpio-lcd driver (or
similar). It ought to be possible to do a device tree binding for at
least this subset of panels.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH 2/4] lcd: platform-lcd: Add support for Hydis hv070wsa lcd panel
Date: Mon, 2 Jan 2012 11:45:59 +0000 [thread overview]
Message-ID: <20120102114559.GE2899@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1325483675-21908-3-git-send-email-thomas.abraham@linaro.org>
On Mon, Jan 02, 2012 at 11:24:33AM +0530, Thomas Abraham wrote:
> +static void lcd_hv070wsa_set_power(struct platform_lcd *plcd, unsigned int pwr)
> +{
> + struct plat_lcd_hydis_hv070wsa_pdata *pdata = plcd->lcd_pdata;
> +
> + gpio_direction_output(pdata->gpio, pwr);
> +}
This doesn't look at all specific to this panel - it's just setting a
GPIO - so it should probably just be a generic gpio-lcd driver (or
similar). It ought to be possible to do a device tree binding for at
least this subset of panels.
next prev parent reply other threads:[~2012-01-02 11:46 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 5:54 [RFC][PATCH 0/4] lcd: platform-lcd: Add lcd panel and device tree support Thomas Abraham
2012-01-02 5:54 ` Thomas Abraham
2012-01-02 5:54 ` [RFC][PATCH 1/4] lcd: platform-lcd: Eliminate need for platform data Thomas Abraham
2012-01-02 5:54 ` Thomas Abraham
2012-01-02 5:54 ` [RFC][PATCH 2/4] lcd: platform-lcd: Add support for Hydis hv070wsa lcd panel Thomas Abraham
2012-01-02 5:54 ` Thomas Abraham
2012-01-02 5:54 ` [RFC][PATCH 3/4] ARM: Exynos: Remove platform data of platform-lcd driver Thomas Abraham
2012-01-02 5:54 ` Thomas Abraham
2012-01-02 5:54 ` [RFC][PATCH 4/4] lcd: platform-lcd: Add device tree support Thomas Abraham
2012-01-02 5:54 ` Thomas Abraham
2012-01-02 5:54 ` Thomas Abraham
2012-01-02 7:34 ` Grant Likely
2012-01-02 7:34 ` Grant Likely
2012-01-02 17:33 ` Thomas Abraham
2012-01-02 17:33 ` Thomas Abraham
2012-01-02 8:02 ` [RFC][PATCH 2/4] lcd: platform-lcd: Add support for Hydis hv070wsa lcd panel Kyungmin Park
2012-01-02 8:02 ` Kyungmin Park
2012-01-02 17:39 ` Thomas Abraham
2012-01-02 17:39 ` Thomas Abraham
2012-01-02 11:45 ` Mark Brown [this message]
2012-01-02 11:45 ` Mark Brown
2012-01-02 17:41 ` Thomas Abraham
2012-01-02 17:41 ` Thomas Abraham
2012-01-02 11:59 ` [RFC][PATCH 1/4] lcd: platform-lcd: Eliminate need for platform data Mark Brown
2012-01-02 11:59 ` Mark Brown
2012-01-02 17:51 ` Thomas Abraham
2012-01-02 17:51 ` Thomas Abraham
2012-01-02 18:13 ` Mark Brown
2012-01-02 18:13 ` Mark Brown
2012-01-03 8:26 ` Thomas Abraham
2012-01-03 8:26 ` Thomas Abraham
2012-01-02 6:48 ` [RFC][PATCH 0/4] lcd: platform-lcd: Add lcd panel and device tree support Olof Johansson
2012-01-02 6:48 ` Olof Johansson
2012-01-02 17:31 ` Thomas Abraham
2012-01-02 17:31 ` Thomas Abraham
2012-01-02 7:34 ` Grant Likely
2012-01-02 7:34 ` Grant Likely
2012-01-03 9:06 ` Lars-Peter Clausen
2012-01-03 9:06 ` Lars-Peter Clausen
2012-01-03 11:54 ` Thomas Abraham
2012-01-03 11:54 ` Thomas Abraham
2012-01-03 12:26 ` Lars-Peter Clausen
2012-01-03 12:26 ` Lars-Peter Clausen
2012-01-03 17:07 ` Thomas Abraham
2012-01-03 17:07 ` Thomas Abraham
2012-01-03 18:36 ` Lars-Peter Clausen
2012-01-03 18:36 ` Lars-Peter Clausen
2012-01-04 6:13 ` Thomas Abraham
2012-01-04 6:13 ` Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120102114559.GE2899@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=augulis.darius@gmail.com \
--cc=ben-linux@fluff.org \
--cc=cbou@mail.ru \
--cc=grant.likely@secretlab.ca \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kwangwoo.lee@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rob.herring@calxeda.com \
--cc=rpurdie@rpsys.net \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.