All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
	linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>,
	Chris Metcalf <cmetcalf@tilera.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
	Matt Mackall <mpm@selenic.com>,
	Sasha Levin <levinsasha928@gmail.com>,
	Rik van Riel <riel@redhat.com>, Andi Kleen <andi@firstfloor.org>,
	Mel Gorman <mel@csn.ul.ie>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH v5 8/8] mm: add vmstat counters for tracking PCP drains
Date: Tue, 3 Jan 2012 14:37:54 -0800	[thread overview]
Message-ID: <20120103143754.f2640d24.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAOtvUMc259XZ5BdOqys3Kbv_u=Qa0matnuFyGrJhMPLtRKKkUA@mail.gmail.com>

On Tue, 3 Jan 2012 21:00:17 +0200
Gilad Ben-Yossef <gilad@benyossef.com> wrote:

> > NAK.
> >
> > PCP_GLOBAL_IPI_SAVED is only useful at development phase. I can't
> > imagine normal admins use it.
> 
> As the description explains, the purpose of the patch is to show why i
> claim the previous
> patch is useful. I did not meant it to be applied to mainline.

Right.

The thing to do is to use this patch to determine the effectiveness of
the preceding patchset and then present a summary of the results in the
other patch's changelog.  This is precisely what you did and the
results look pretty good.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
	linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>,
	Chris Metcalf <cmetcalf@tilera.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
	Matt Mackall <mpm@selenic.com>,
	Sasha Levin <levinsasha928@gmail.com>,
	Rik van Riel <riel@redhat.com>, Andi Kleen <andi@firstfloor.org>,
	Mel Gorman <mel@csn.ul.ie>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH v5 8/8] mm: add vmstat counters for tracking PCP drains
Date: Tue, 3 Jan 2012 14:37:54 -0800	[thread overview]
Message-ID: <20120103143754.f2640d24.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAOtvUMc259XZ5BdOqys3Kbv_u=Qa0matnuFyGrJhMPLtRKKkUA@mail.gmail.com>

On Tue, 3 Jan 2012 21:00:17 +0200
Gilad Ben-Yossef <gilad@benyossef.com> wrote:

> > NAK.
> >
> > PCP_GLOBAL_IPI_SAVED is only useful at development phase. I can't
> > imagine normal admins use it.
> 
> As the description explains, the purpose of the patch is to show why i
> claim the previous
> patch is useful. I did not meant it to be applied to mainline.

Right.

The thing to do is to use this patch to determine the effectiveness of
the preceding patchset and then present a summary of the results in the
other patch's changelog.  This is precisely what you did and the
results look pretty good.



  parent reply	other threads:[~2012-01-03 22:37 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-02 10:24 [PATCH v5 0/8] Reduce cross CPU IPI interference Gilad Ben-Yossef
2012-01-02 10:24 ` [PATCH v5 1/8] smp: Introduce a generic on_each_cpu_mask function Gilad Ben-Yossef
2012-01-02 10:24   ` Gilad Ben-Yossef
2012-01-03  7:51   ` Michal Nazarewicz
2012-01-03  7:51     ` Michal Nazarewicz
2012-01-03  7:51     ` Michal Nazarewicz
2012-01-03  8:12     ` Gilad Ben-Yossef
2012-01-03  8:12       ` Gilad Ben-Yossef
2012-01-03  8:57       ` Michal Nazarewicz
2012-01-03  8:57         ` Michal Nazarewicz
2012-01-03  8:57         ` Michal Nazarewicz
2012-01-03 22:26   ` Andrew Morton
2012-01-03 22:26     ` Andrew Morton
2012-01-05 13:17     ` Michal Nazarewicz
2012-01-05 13:17       ` Michal Nazarewicz
2012-01-08 16:04     ` Gilad Ben-Yossef
2012-01-08 16:04       ` Gilad Ben-Yossef
2012-01-02 10:24 ` [PATCH v5 2/8] arm: Move arm over to generic on_each_cpu_mask Gilad Ben-Yossef
2012-01-02 10:24   ` Gilad Ben-Yossef
2012-01-02 10:24 ` [PATCH v5 3/8] tile: Move tile to use " Gilad Ben-Yossef
2012-01-02 10:24   ` Gilad Ben-Yossef
2012-01-02 10:24 ` [PATCH v5 4/8] smp: Add func to IPI cpus based on parameter func Gilad Ben-Yossef
2012-01-02 10:24   ` Gilad Ben-Yossef
2012-01-03 22:34   ` Andrew Morton
2012-01-03 22:34     ` Andrew Morton
2012-01-08 16:09     ` Gilad Ben-Yossef
2012-01-08 16:09       ` Gilad Ben-Yossef
2012-01-02 10:24 ` [PATCH v5 5/8] slub: Only IPI CPUs that have per cpu obj to flush Gilad Ben-Yossef
2012-01-02 10:24   ` Gilad Ben-Yossef
2012-01-02 10:24 ` [PATCH v5 6/8] fs: only send IPI to invalidate LRU BH when needed Gilad Ben-Yossef
2012-01-02 10:24   ` Gilad Ben-Yossef
2012-01-02 10:24 ` [PATCH v5 7/8] mm: Only IPI CPUs to drain local pages if they exist Gilad Ben-Yossef
2012-01-02 10:24   ` Gilad Ben-Yossef
2012-01-03 17:45   ` KOSAKI Motohiro
2012-01-03 17:45     ` KOSAKI Motohiro
2012-01-03 18:58     ` Gilad Ben-Yossef
2012-01-03 18:58       ` Gilad Ben-Yossef
2012-01-03 22:02       ` KOSAKI Motohiro
2012-01-03 22:02         ` KOSAKI Motohiro
2012-01-05 14:20     ` Mel Gorman
2012-01-05 14:20       ` Mel Gorman
2012-01-05 14:40       ` Russell King - ARM Linux
2012-01-05 14:40         ` Russell King - ARM Linux
2012-01-05 15:24         ` Peter Zijlstra
2012-01-05 15:24           ` Peter Zijlstra
2012-01-05 16:17         ` Mel Gorman
2012-01-05 16:17           ` Mel Gorman
2012-01-05 16:35           ` Russell King - ARM Linux
2012-01-05 16:35             ` Russell King - ARM Linux
2012-01-05 18:35             ` Paul E. McKenney
2012-01-05 18:35               ` Paul E. McKenney
2012-01-05 22:21               ` Mel Gorman
2012-01-05 22:21                 ` Mel Gorman
2012-01-06  6:06                 ` Srivatsa S. Bhat
2012-01-06  6:06                   ` Srivatsa S. Bhat
2012-01-06 10:46                   ` Mel Gorman
2012-01-06 10:46                     ` Mel Gorman
2012-01-06 13:28                 ` Greg KH
2012-01-06 13:28                   ` Greg KH
2012-01-06 14:09                   ` Mel Gorman
2012-01-06 14:09                     ` Mel Gorman
2012-01-05 22:06           ` Andrew Morton
2012-01-05 22:06             ` Andrew Morton
2012-01-05 22:31             ` Mel Gorman
2012-01-05 22:31               ` Mel Gorman
2012-01-05 23:19               ` Andrew Morton
2012-01-05 23:19                 ` Andrew Morton
2012-01-09 17:25                 ` Mel Gorman
2012-01-09 17:25                   ` Mel Gorman
2012-01-07 16:52           ` Paul E. McKenney
2012-01-07 16:52             ` Paul E. McKenney
2012-01-07 17:05             ` Paul E. McKenney
2012-01-07 17:05               ` Paul E. McKenney
2012-01-05 15:54   ` Mel Gorman
2012-01-05 15:54     ` Mel Gorman
2012-01-08 16:01     ` Gilad Ben-Yossef
2012-01-08 16:01       ` Gilad Ben-Yossef
2012-01-02 10:24 ` [PATCH v5 8/8] mm: add vmstat counters for tracking PCP drains Gilad Ben-Yossef
2012-01-02 10:24   ` Gilad Ben-Yossef
2012-01-03 17:47   ` KOSAKI Motohiro
2012-01-03 17:47     ` KOSAKI Motohiro
2012-01-03 19:00     ` Gilad Ben-Yossef
2012-01-03 19:00       ` Gilad Ben-Yossef
2012-01-03 22:13       ` KOSAKI Motohiro
2012-01-03 22:13         ` KOSAKI Motohiro
2012-01-03 22:37       ` Andrew Morton [this message]
2012-01-03 22:37         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120103143754.f2640d24.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=andi@firstfloor.org \
    --cc=avi@redhat.com \
    --cc=cl@linux.com \
    --cc=cmetcalf@tilera.com \
    --cc=fweisbec@gmail.com \
    --cc=gilad@benyossef.com \
    --cc=kosaki.motohiro@gmail.com \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=mpm@selenic.com \
    --cc=penberg@kernel.org \
    --cc=riel@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.