From: Ted Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: Yongqiang Yang <xiaoqiangnk@gmail.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH V6 RESEND] ext4: add new online resize
Date: Tue, 3 Jan 2012 15:50:48 -0500 [thread overview]
Message-ID: <20120103205048.GD30502@thunk.org> (raw)
In-Reply-To: <9CB90BD7-CB4D-42D5-9254-A0455ADB0E15@whamcloud.com>
On Sat, Dec 31, 2011 at 10:40:24AM -0700, Andreas Dilger wrote:
> The main issue I have with this patch is that the series starts by
> adding a bunch of unused functions, and only wires them I to the
> existing resize code at the very end.
>
> A better approach would be to have the early patches refactor the
> existing functions so that they are used by the current resize code,
> and the new resize functionality is enabled at the end.
>
> That allows verifying that the existing code continues to work
> through the entire series, and that the functions being added
> actually work properly even before the new ioctl is added.
I agree with Andreas that in general this is better way to ago,
although as long as regression testing is done with both the new
(v1.42) resize2fs as well as the old (v1.41.x) resize2fs, it's OK.
(Regressions with the v1.41.x resize2fs are just as important because
many people will be upgrading to the new kernel without necessarily
upgrading their e2fsprogs userspace programs, and we can't let them
break.)
I've done some quick regression testing using both the old and new
resize2fs programs, however, and it looks good. I'm going to take a
quick final scan over the patches, but I think they are ready for
inclusion.
- Ted
prev parent reply other threads:[~2012-01-04 3:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 10:59 [PATCH V6 RESEND] ext4: add new online resize Yongqiang Yang
2011-12-30 10:59 ` [PATCH V6 RESEND 01/15] ext4: add a function which extends a group without checking parameters Yongqiang Yang
2012-01-03 21:07 ` Ted Ts'o
2012-01-04 3:59 ` Yongqiang Yang
2011-12-30 10:59 ` [PATCH V6 RESEND 02/15] ext4: add a function which adds a new desc to a fs Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 03/15] ext4: add a function which sets up a new group desc Yongqiang Yang
2012-01-04 2:24 ` Ted Ts'o
2012-01-04 4:02 ` Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 04/15] ext4: add a function which updates super block Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 05/15] ext4: add a structure which will be used by 64bit-resize interface Yongqiang Yang
2012-01-04 2:30 ` Ted Ts'o
2011-12-30 11:00 ` [PATCH V6 RESEND 06/15] ext4: add a function which sets up group blocks of a flex groups Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 07/15] ext4: add a function which adds several group descriptors Yongqiang Yang
2012-01-04 2:44 ` Ted Ts'o
2011-12-30 11:00 ` [PATCH V6 RESEND 08/15] ext4: add a function which sets up a flex groups each time Yongqiang Yang
2012-01-04 2:46 ` Ted Ts'o
2011-12-30 11:00 ` [PATCH V6 RESEND 09/15] ext4: enable ext4_update_super() to handle a flex groups Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 10/15] ext4: pass verify_reserved_gdb() the number of group decriptors Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 11/15] ext4: add a new function which allocates bitmaps and inode tables Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 12/15] ext4: add a new function which adds a flex group to a fs Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 13/15] ext4: add new online resize interface Yongqiang Yang
2012-01-04 5:03 ` Ted Ts'o
2011-12-30 11:00 ` [PATCH V6 RESEND 14/15] ext4: let ext4_group_extend() use common code Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 15/15] ext4: let ext4_group_add() " Yongqiang Yang
2011-12-31 17:40 ` [PATCH V6 RESEND] ext4: add new online resize Andreas Dilger
2012-01-03 20:50 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120103205048.GD30502@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.