From: Ted Ts'o <tytso@mit.edu>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH V6 RESEND 05/15] ext4: add a structure which will be used by 64bit-resize interface
Date: Tue, 3 Jan 2012 21:30:53 -0500 [thread overview]
Message-ID: <20120104023053.GG30502@thunk.org> (raw)
In-Reply-To: <1325242812-27005-6-git-send-email-xiaoqiangnk@gmail.com>
On Fri, Dec 30, 2011 at 07:00:02PM +0800, Yongqiang Yang wrote:
> +void free_flex_gd(struct ext4_new_flex_group_data *flex_gd)
This should be static, so we don't leak symbols that don't begin with
"ext4_" into kernel namespace. I've checked and future users of this
function are in fs/ext4/resize.c, so there's no reason for this not to
be non-static.
(A good thing to do while doing development is to run "nm ext4.ko" and
check for exported symbols that you aren't expecting.)
Again, I'll fix this as a minor nit.
- Ted
next prev parent reply other threads:[~2012-01-04 3:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 10:59 [PATCH V6 RESEND] ext4: add new online resize Yongqiang Yang
2011-12-30 10:59 ` [PATCH V6 RESEND 01/15] ext4: add a function which extends a group without checking parameters Yongqiang Yang
2012-01-03 21:07 ` Ted Ts'o
2012-01-04 3:59 ` Yongqiang Yang
2011-12-30 10:59 ` [PATCH V6 RESEND 02/15] ext4: add a function which adds a new desc to a fs Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 03/15] ext4: add a function which sets up a new group desc Yongqiang Yang
2012-01-04 2:24 ` Ted Ts'o
2012-01-04 4:02 ` Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 04/15] ext4: add a function which updates super block Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 05/15] ext4: add a structure which will be used by 64bit-resize interface Yongqiang Yang
2012-01-04 2:30 ` Ted Ts'o [this message]
2011-12-30 11:00 ` [PATCH V6 RESEND 06/15] ext4: add a function which sets up group blocks of a flex groups Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 07/15] ext4: add a function which adds several group descriptors Yongqiang Yang
2012-01-04 2:44 ` Ted Ts'o
2011-12-30 11:00 ` [PATCH V6 RESEND 08/15] ext4: add a function which sets up a flex groups each time Yongqiang Yang
2012-01-04 2:46 ` Ted Ts'o
2011-12-30 11:00 ` [PATCH V6 RESEND 09/15] ext4: enable ext4_update_super() to handle a flex groups Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 10/15] ext4: pass verify_reserved_gdb() the number of group decriptors Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 11/15] ext4: add a new function which allocates bitmaps and inode tables Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 12/15] ext4: add a new function which adds a flex group to a fs Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 13/15] ext4: add new online resize interface Yongqiang Yang
2012-01-04 5:03 ` Ted Ts'o
2011-12-30 11:00 ` [PATCH V6 RESEND 14/15] ext4: let ext4_group_extend() use common code Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 15/15] ext4: let ext4_group_add() " Yongqiang Yang
2011-12-31 17:40 ` [PATCH V6 RESEND] ext4: add new online resize Andreas Dilger
2012-01-03 20:50 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104023053.GG30502@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.