From: Andrew Morton <akpm@linux-foundation.org>
To: Hugh Dickins <hughd@google.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
linux-mm@kvack.org, Mel Gorman <mel@csn.ul.ie>
Subject: Re: [PATCH 3/3] mm: take pagevecs off reclaim stack
Date: Wed, 4 Jan 2012 12:20:25 -0800 [thread overview]
Message-ID: <20120104122025.b0890e7e.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LSU.2.00.1201031900140.1378@eggly.anvils>
On Tue, 3 Jan 2012 19:22:42 -0800 (PST)
Hugh Dickins <hughd@google.com> wrote:
> > > >
> > > > Now, a way out here is to remove lumpy reclaim (please). And make the
> > > > problem not come back by promising to never call putback_lru_pages(lots
> > > > of pages) (how do we do this?).
> > >
> > > We can very easily put a counter in it, doing a spin_unlock_irq every
> > > time we hit the max. Nothing prevents that, it's just an excrescence
> > > I'd have preferred to omit and have not today implemented.
> >
> > Yes. It's ultra-cautious, but perhaps we should do this at least until
> > lumpy goes away.
>
> I don't think you'll accept my observations above as excuse to do
> nothing, but please clarify which you think is more cautious. Should
> I or should I not break up the isolating end in the same way as the
> putting back?
If we already have the latency problem at the isolate_lru_pages() stage
then I suppose we can assume that nobody is noticing it, so we'll
probably be OK.
For a while. Someone will complain at some stage and we'll probably
end up busting this work into chunks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-01-04 20:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 4:32 [PATCH 0/3] mm: three minor vmscan improvements Hugh Dickins
2011-12-29 4:35 ` [PATCH 1/3] mm: test PageSwapBacked in lumpy reclaim Hugh Dickins
2011-12-29 5:06 ` KOSAKI Motohiro
2012-01-04 1:23 ` Minchan Kim
2012-01-05 6:03 ` KAMEZAWA Hiroyuki
2011-12-29 4:36 ` [PATCH 2/3] mm: cond_resched in scan_mapping_unevictable_pages Hugh Dickins
2011-12-29 5:14 ` KOSAKI Motohiro
2011-12-29 5:48 ` Hugh Dickins
2011-12-29 22:46 ` Hugh Dickins
2011-12-29 4:39 ` [PATCH 3/3] mm: take pagevecs off reclaim stack Hugh Dickins
2011-12-29 5:42 ` KOSAKI Motohiro
2011-12-29 11:18 ` Konstantin Khlebnikov
2011-12-29 22:20 ` Hugh Dickins
2011-12-29 22:55 ` Andrew Morton
2011-12-29 23:27 ` Hugh Dickins
2011-12-30 0:24 ` KOSAKI Motohiro
2011-12-30 1:55 ` Hugh Dickins
2011-12-30 3:59 ` Andrew Morton
2011-12-30 15:51 ` Mel Gorman
2012-01-01 7:18 ` Hugh Dickins
2012-01-03 23:12 ` Andrew Morton
2012-01-03 23:17 ` KOSAKI Motohiro
2012-01-03 23:29 ` Andrew Morton
2012-01-04 0:03 ` KOSAKI Motohiro
2012-01-04 3:22 ` Hugh Dickins
2012-01-04 20:20 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104122025.b0890e7e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=khlebnikov@openvz.org \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.