From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
linux-mm@kvack.org
Subject: Re: [PATCH 3/3] mm: take pagevecs off reclaim stack
Date: Thu, 29 Dec 2011 00:42:14 -0500 [thread overview]
Message-ID: <4EFBFDB6.2060205@gmail.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1112282037000.1362@eggly.anvils>
(12/28/11 11:39 PM), Hugh Dickins wrote:
> Replace pagevecs in putback_lru_pages() and move_active_pages_to_lru()
> by lists of pages_to_free: then apply Konstantin Khlebnikov's
> free_hot_cold_page_list() to them instead of pagevec_release().
>
> Which simplifies the flow (no need to drop and retake lock whenever
> pagevec fills up) and reduces stale addresses in stack backtraces
> (which often showed through the pagevecs); but more importantly,
> removes another 120 bytes from the deepest stacks in page reclaim.
> Although I've not recently seen an actual stack overflow here with
> a vanilla kernel, move_active_pages_to_lru() has often featured in
> deep backtraces.
>
> However, free_hot_cold_page_list() does not handle compound pages
> (nor need it: a Transparent HugePage would have been split by the
> time it reaches the call in shrink_page_list()), but it is possible
> for putback_lru_pages() or move_active_pages_to_lru() to be left
> holding the last reference on a THP, so must exclude the unlikely
> compound case before putting on pages_to_free.
>
> Remove pagevec_strip(), its work now done in move_active_pages_to_lru().
> The pagevec in scan_mapping_unevictable_pages() remains in mm/vmscan.c,
> but that is never on the reclaim path, and cannot be replaced by a list.
>
> Signed-off-by: Hugh Dickins<hughd@google.com>
I haven't found any incorrect.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-12-29 5:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 4:32 [PATCH 0/3] mm: three minor vmscan improvements Hugh Dickins
2011-12-29 4:35 ` [PATCH 1/3] mm: test PageSwapBacked in lumpy reclaim Hugh Dickins
2011-12-29 5:06 ` KOSAKI Motohiro
2012-01-04 1:23 ` Minchan Kim
2012-01-05 6:03 ` KAMEZAWA Hiroyuki
2011-12-29 4:36 ` [PATCH 2/3] mm: cond_resched in scan_mapping_unevictable_pages Hugh Dickins
2011-12-29 5:14 ` KOSAKI Motohiro
2011-12-29 5:48 ` Hugh Dickins
2011-12-29 22:46 ` Hugh Dickins
2011-12-29 4:39 ` [PATCH 3/3] mm: take pagevecs off reclaim stack Hugh Dickins
2011-12-29 5:42 ` KOSAKI Motohiro [this message]
2011-12-29 11:18 ` Konstantin Khlebnikov
2011-12-29 22:20 ` Hugh Dickins
2011-12-29 22:55 ` Andrew Morton
2011-12-29 23:27 ` Hugh Dickins
2011-12-30 0:24 ` KOSAKI Motohiro
2011-12-30 1:55 ` Hugh Dickins
2011-12-30 3:59 ` Andrew Morton
2011-12-30 15:51 ` Mel Gorman
2012-01-01 7:18 ` Hugh Dickins
2012-01-03 23:12 ` Andrew Morton
2012-01-03 23:17 ` KOSAKI Motohiro
2012-01-03 23:29 ` Andrew Morton
2012-01-04 0:03 ` KOSAKI Motohiro
2012-01-04 3:22 ` Hugh Dickins
2012-01-04 20:20 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFBFDB6.2060205@gmail.com \
--to=kosaki.motohiro@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=khlebnikov@openvz.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.