From: "Heiko Stübner" <heiko@sntech.de>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
ben-linux@fluff.org, a.zummo@towertech.it,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, rtc-linux@googlegroups.com
Subject: Re: [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block
Date: Wed, 4 Jan 2012 15:12:54 +0100 [thread overview]
Message-ID: <201201041512.55126.heiko@sntech.de> (raw)
In-Reply-To: <201201041251.42509.heiko@sntech.de>
Hi Kgene,
Am Mittwoch, 4. Januar 2012, 12:51:41 schrieb Heiko Stübner:
> Hi Sylwester,
>
> Am Mittwoch, 4. Januar 2012, 11:43:45 schrieb Sylwester Nawrocki:
> > Hello,
> >
> > On 12/21/2011 10:16 AM, Heiko Stübner wrote:
> > > Use the data field of of_device_id to hold the type for
> > > s3c_cpu_type.
> > >
> > > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > > Reviewed-by: Thomas Abraham <thomas.abraham@linaro.org>
> > > ---
> >
> > This patch makes compilation with CONFIG_OF enabled fail with errors
> > and warnings:
> >
> > drivers/rtc/rtc-s3c.c: In function ‘s3c_rtc_get_driver_data’:
> > drivers/rtc/rtc-s3c.c:454: warning: return makes integer from pointer
> > without a cast
> > drivers/rtc/rtc-s3c.c: At top level:
> > drivers/rtc/rtc-s3c.c:674: error: request for member ‘data’ in something
> > not a structure or union
> > drivers/rtc/rtc-s3c.c:677: error: request for member ‘data’ in something
> > not a structure or union
> > drivers/rtc/rtc-s3c.c:680: error: request for member ‘data’ in something
> > not a structure or union
> > drivers/rtc/rtc-s3c.c:683: error: request for member ‘data’ in something
> > not a structure or union
> > make[2]: *** [drivers/rtc/rtc-s3c.o] Error 1
>
> thanks for spotting this.
>
> @kgene: Should this go on top of the rtc series, or should I prepare a v4
> with these fixes included?
never mind, I did both.
In reply to this mail you will find:
- a single patch on top of the 4 original patches, fixing the problems
sylwester reported
- a v4 of the original series including the fixes to the problems, based on
the code that you have in your rtc-branch
Please pick the apropriate variant to fix the problem :-)
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block
Date: Wed, 4 Jan 2012 15:12:54 +0100 [thread overview]
Message-ID: <201201041512.55126.heiko@sntech.de> (raw)
In-Reply-To: <201201041251.42509.heiko@sntech.de>
Hi Kgene,
Am Mittwoch, 4. Januar 2012, 12:51:41 schrieb Heiko St?bner:
> Hi Sylwester,
>
> Am Mittwoch, 4. Januar 2012, 11:43:45 schrieb Sylwester Nawrocki:
> > Hello,
> >
> > On 12/21/2011 10:16 AM, Heiko St?bner wrote:
> > > Use the data field of of_device_id to hold the type for
> > > s3c_cpu_type.
> > >
> > > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > > Reviewed-by: Thomas Abraham <thomas.abraham@linaro.org>
> > > ---
> >
> > This patch makes compilation with CONFIG_OF enabled fail with errors
> > and warnings:
> >
> > drivers/rtc/rtc-s3c.c: In function ?s3c_rtc_get_driver_data?:
> > drivers/rtc/rtc-s3c.c:454: warning: return makes integer from pointer
> > without a cast
> > drivers/rtc/rtc-s3c.c: At top level:
> > drivers/rtc/rtc-s3c.c:674: error: request for member ?data? in something
> > not a structure or union
> > drivers/rtc/rtc-s3c.c:677: error: request for member ?data? in something
> > not a structure or union
> > drivers/rtc/rtc-s3c.c:680: error: request for member ?data? in something
> > not a structure or union
> > drivers/rtc/rtc-s3c.c:683: error: request for member ?data? in something
> > not a structure or union
> > make[2]: *** [drivers/rtc/rtc-s3c.o] Error 1
>
> thanks for spotting this.
>
> @kgene: Should this go on top of the rtc series, or should I prepare a v4
> with these fixes included?
never mind, I did both.
In reply to this mail you will find:
- a single patch on top of the 4 original patches, fixing the problems
sylwester reported
- a v4 of the original series including the fixes to the problems, based on
the code that you have in your rtc-branch
Please pick the apropriate variant to fix the problem :-)
Heiko
next prev parent reply other threads:[~2012-01-04 14:13 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 9:14 [PATCH v3 0/4] Implement RTC support for S3C2443/S3C2416/S3C2450 Heiko Stübner
2011-12-21 9:14 ` Heiko Stübner
2011-12-21 9:16 ` [PATCH 1/4] ARM: SAMSUNG: cleanup of rtc register definitions Heiko Stübner
2011-12-21 9:16 ` Heiko Stübner
2011-12-21 9:16 ` [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block Heiko Stübner
2011-12-21 9:16 ` Heiko Stübner
2012-01-04 10:43 ` Sylwester Nawrocki
2012-01-04 10:43 ` Sylwester Nawrocki
2012-01-04 11:51 ` Heiko Stübner
2012-01-04 11:51 ` Heiko Stübner
2012-01-04 14:12 ` Heiko Stübner [this message]
2012-01-04 14:12 ` Heiko Stübner
2012-01-04 14:14 ` [PATCH] rtc-s3c: Fix breakage introduced by S3C2443/S3C2416 support Heiko Stübner
2012-01-04 14:14 ` Heiko Stübner
2012-01-05 2:32 ` Kukjin Kim
2012-01-05 2:32 ` Kukjin Kim
2012-01-04 14:14 ` [PATCH v4 0/4] Implement RTC support for S3C2443/S3C2416/S3C2450 Heiko Stübner
2012-01-04 14:14 ` Heiko Stübner
2012-01-04 14:15 ` [PATCH 1/4] ARM: SAMSUNG: cleanup of rtc register definitions Heiko Stübner
2012-01-04 14:15 ` Heiko Stübner
2012-01-04 22:14 ` Russell King - ARM Linux
2012-01-04 22:14 ` Russell King - ARM Linux
2012-01-04 14:16 ` [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block Heiko Stübner
2012-01-04 14:16 ` Heiko Stübner
2012-01-04 14:16 ` [PATCH 3/4] rtc-s3c: add variants for S3C2443 and S3C2416 Heiko Stübner
2012-01-04 14:16 ` Heiko Stübner
2012-01-04 14:17 ` [PATCH 4/4] ARM: S3C2443/S3C2416: add s3c_rtc_setname and rename rtc devices Heiko Stübner
2012-01-04 14:17 ` Heiko Stübner
2012-01-05 2:32 ` [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block Kukjin Kim
2012-01-05 2:32 ` Kukjin Kim
2011-12-21 9:17 ` [PATCH 3/4] rtc-s3c: add variants for S3C2443 and S3C2416 Heiko Stübner
2011-12-21 9:17 ` Heiko Stübner
2011-12-21 9:18 ` [PATCH 4/4] ARM: S3C2443/S3C2416: add s3c_rtc_setname and rename rtc devices Heiko Stübner
2011-12-21 9:18 ` Heiko Stübner
-- strict thread matches above, loose matches on Subject: below --
2011-12-12 14:43 [PATCH v2 0/4] Implement RTC support for S3C2443/S3C2416/S3C2450 Heiko Stübner
2011-12-12 14:46 ` [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block Heiko Stübner
2011-12-12 14:46 ` Heiko Stübner
2011-12-09 9:46 [PATCH 0/4] Implement RTC support for S3C2443/S3C2416/S3C2450 Heiko Stübner
2011-12-09 9:50 ` [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block Heiko Stübner
2011-12-09 9:50 ` Heiko Stübner
2011-12-11 5:47 ` Thomas Abraham
2011-12-11 5:47 ` Thomas Abraham
2011-12-12 12:51 ` Heiko Stübner
2011-12-12 12:51 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201041512.55126.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=a.zummo@towertech.it \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.