From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org
Subject: Re: [PATCHv3 1/3] gpio: add a driver for the Synopsys DesignWare APB GPIO block
Date: Wed, 4 Jan 2012 11:21:33 -0700 [thread overview]
Message-ID: <20120104182133.GS15503@ponder.secretlab.ca> (raw)
In-Reply-To: <20120102132500.GB18443-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Mon, Jan 02, 2012 at 01:25:00PM +0000, Mark Brown wrote:
> On Mon, Jan 02, 2012 at 12:53:16PM +0000, Jamie Iles wrote:
> > The Synopsys DesignWare block is used in some ARM devices (picoxcell)
> > and can be configured to provide multiple banks of GPIO pins.
> >
> > v3: - depend on rather than select IRQ_DOMAIN
> > - split IRQ support into a separate patch
> > v2: - use Rob Herring's irqdomain in generic irq chip patches
> > - use reg property to indicate bank index
> > - support irqs on both edges based on LinusW's u300 driver
>
> Put stuff like this after the ---, it shouldn't end up in git history.
I disagree. Keeping the revision history in the git commit is
actually quite useful when trying to figure out which version of a
patch actually got applied. I'm asking patch authors to keep it above
the ---
g.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Jamie Iles <jamie@jamieiles.com>,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linus.walleij@stericsson.com
Subject: Re: [PATCHv3 1/3] gpio: add a driver for the Synopsys DesignWare APB GPIO block
Date: Wed, 4 Jan 2012 11:21:33 -0700 [thread overview]
Message-ID: <20120104182133.GS15503@ponder.secretlab.ca> (raw)
In-Reply-To: <20120102132500.GB18443@sirena.org.uk>
On Mon, Jan 02, 2012 at 01:25:00PM +0000, Mark Brown wrote:
> On Mon, Jan 02, 2012 at 12:53:16PM +0000, Jamie Iles wrote:
> > The Synopsys DesignWare block is used in some ARM devices (picoxcell)
> > and can be configured to provide multiple banks of GPIO pins.
> >
> > v3: - depend on rather than select IRQ_DOMAIN
> > - split IRQ support into a separate patch
> > v2: - use Rob Herring's irqdomain in generic irq chip patches
> > - use reg property to indicate bank index
> > - support irqs on both edges based on LinusW's u300 driver
>
> Put stuff like this after the ---, it shouldn't end up in git history.
I disagree. Keeping the revision history in the git commit is
actually quite useful when trying to figure out which version of a
patch actually got applied. I'm asking patch authors to keep it above
the ---
g.
next prev parent reply other threads:[~2012-01-04 18:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 12:53 [PATCHv3 0/3] Synopsys DesignWare GPIO support Jamie Iles
[not found] ` <1325508798-25439-1-git-send-email-jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
2012-01-02 12:53 ` [PATCHv3 1/3] gpio: add a driver for the Synopsys DesignWare APB GPIO block Jamie Iles
2012-01-02 12:53 ` Jamie Iles
2012-01-02 13:25 ` Mark Brown
2012-01-02 13:48 ` Linus Walleij
2012-01-04 18:24 ` Grant Likely
[not found] ` <20120102132500.GB18443-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-01-02 13:51 ` Jamie Iles
2012-01-02 13:51 ` Jamie Iles
2012-01-02 14:54 ` Mark Brown
2012-01-02 14:54 ` Mark Brown
2012-01-04 18:21 ` Grant Likely [this message]
2012-01-04 18:21 ` Grant Likely
2012-01-05 5:46 ` Mark Brown
2012-01-02 12:53 ` [PATCHv3 2/3] gpio: dwapb: add support for GPIO interrupts Jamie Iles
2012-01-02 12:53 ` [PATCHv3 3/3] ARM: picoxcell: use new Synopsys Designware GPIO binding Jamie Iles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104182133.GS15503@ponder.secretlab.ca \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.