From: Daniel Vetter <daniel@ffwll.ch>
To: Keith Packard <keithp@keithp.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
Eugeni Dodonov <eugeni.dodonov@intel.com>,
stable@kernel.org
Subject: Re: [PATCH] drm/i915: paper over missed irq issues with force wake vodoo
Date: Thu, 5 Jan 2012 12:13:58 +0100 [thread overview]
Message-ID: <20120105111358.GA3831@phenom.ffwll.local> (raw)
In-Reply-To: <86d3aylw83.fsf@sumi.keithp.com>
On Wed, Jan 04, 2012 at 06:27:40PM -0800, Keith Packard wrote:
> On Wed, 4 Jan 2012 19:40:45 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>
> > Two things seem to do the trick on my ivb machine here:
> > - prevent the gt from powering down while waiting for seqno
> > notification interrupts by grabbing the force_wake in get_irq (and
> > dropping it in put_irq again).
> > - ordering writes from the ring's CS by reading a CS register, ACTHD
> > seems to work.
>
> If this works reliably, you'll deserve a medal...
I've removed the HWSTAM workaround on my branch and both my ivb and snb
seem to still work. So I'm still hopeful that this actually works ;-)
Ben promised to beat on it with his machines, too, but I fear Eric is way
too busy with the finishing touches for the OGL 3.0 frenzy atm.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-01-05 11:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 16:52 [PATCH] drm/i915: paper over missed irq issues with force wake vodoo Daniel Vetter
2012-01-04 18:15 ` Eugeni Dodonov
2012-01-04 18:40 ` Daniel Vetter
2012-01-05 2:27 ` Keith Packard
2012-01-05 11:13 ` Daniel Vetter [this message]
2012-01-05 11:23 ` Eugeni Dodonov
2012-01-05 22:11 ` [PATCH] drm/i915: rip out the HWSTAM missed irq workaround Daniel Vetter
2012-01-05 23:29 ` Ben Widawsky
2012-01-06 16:03 ` Eugeni Dodonov
2012-01-09 22:00 ` Keith Packard
2012-01-09 23:39 ` Daniel Vetter
2012-01-10 2:09 ` Keith Packard
2012-01-10 7:58 ` Daniel Vetter
2012-01-18 0:24 ` Ben Widawsky
2012-01-10 12:20 ` [PATCH] drm/i915: paper over missed irq issues with force wake vodoo Daniel Vetter
2012-01-11 0:51 ` Eric Anholt
2012-01-11 4:44 ` Keith Packard
2012-01-11 6:21 ` Ben Widawsky
2012-01-11 9:59 ` Daniel Vetter
2012-01-11 5:41 ` Kenneth Graunke
2012-01-13 16:42 ` Keith Packard
2012-01-13 23:52 ` Daniel Vetter
2012-01-13 23:55 ` Daniel Vetter
2012-01-14 0:11 ` Keith Packard
2012-01-14 0:31 ` Daniel Vetter
2012-01-14 0:50 ` Keith Packard
2012-01-14 12:12 ` Daniel Vetter
2012-01-15 6:35 ` Keith Packard
2012-01-15 15:03 ` Daniel Vetter
2012-01-16 0:06 ` Keith Packard
2012-01-05 23:29 ` Ben Widawsky
2012-01-08 13:01 ` Daniel Vetter
2012-01-09 5:09 ` Keith Packard
2012-01-06 20:56 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105111358.GA3831@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.