Re: [PATCH 2/2] brcmfmac: use existing net_device_stats

[Stephen Hemminger <shemminger@vyatta.com>]

On Thu, 5 Jan 2012 20:12:12 +0100
"Arend van Spriel" <arend@broadcom.com> wrote:

> On 01/05/2012 07:39 PM, Stephen Hemminger wrote:
> > Minor space savings. Compile tested only.
> > 
> 
> This is actually not going to work. The struct brcmf_if represents
> individual interfaces which each have their own device statistics.
> 
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> > 
> > 
> > --- a/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c	2012-01-05 10:02:57.488495190 -0800
> > +++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c	2012-01-05 10:09:58.536972268 -0800
> > @@ -56,7 +56,6 @@ struct brcmf_if {
> >  	struct brcmf_info *info;	/* back pointer to brcmf_info */
> >  	/* OS/stack specifics */
> >  	struct net_device *ndev;
> > -	struct net_device_stats stats;
> >  	int idx;		/* iface idx in dongle */
> >  	int state;		/* interface state */
> >  	u8 mac_addr[ETH_ALEN];	/* assigned MAC address */
> > @@ -526,7 +525,6 @@ static struct net_device_stats *brcmf_ne
> >  {
> >  	struct brcmf_info *drvr_priv = *(struct brcmf_info **)
> >  					netdev_priv(ndev);
> > -	struct brcmf_if *ifp;
> >  	int ifidx;
> >  
> 
> Gr. AvS
> 

Why not, if you  look it is only used during the aggregation and return
of netdevice stats.