From: "Arend van Spriel" <arend@broadcom.com>
To: "Stephen Hemminger" <shemminger@vyatta.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>
Subject: Re: [PATCH 2/2] brcmfmac: use existing net_device_stats
Date: Thu, 5 Jan 2012 20:12:12 +0100 [thread overview]
Message-ID: <4F05F60C.5030406@broadcom.com> (raw)
In-Reply-To: <20120105184000.572918423@vyatta.com>
On 01/05/2012 07:39 PM, Stephen Hemminger wrote:
> Minor space savings. Compile tested only.
>
This is actually not going to work. The struct brcmf_if represents
individual interfaces which each have their own device statistics.
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
>
> --- a/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c 2012-01-05 10:02:57.488495190 -0800
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c 2012-01-05 10:09:58.536972268 -0800
> @@ -56,7 +56,6 @@ struct brcmf_if {
> struct brcmf_info *info; /* back pointer to brcmf_info */
> /* OS/stack specifics */
> struct net_device *ndev;
> - struct net_device_stats stats;
> int idx; /* iface idx in dongle */
> int state; /* interface state */
> u8 mac_addr[ETH_ALEN]; /* assigned MAC address */
> @@ -526,7 +525,6 @@ static struct net_device_stats *brcmf_ne
> {
> struct brcmf_info *drvr_priv = *(struct brcmf_info **)
> netdev_priv(ndev);
> - struct brcmf_if *ifp;
> int ifidx;
>
Gr. AvS
next prev parent reply other threads:[~2012-01-05 19:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120105183947.295358582@vyatta.com>
2012-01-05 18:39 ` [PATCH 1/3] ath6kl: make net_device_ops const Stephen Hemminger
2012-01-09 14:40 ` Kalle Valo
2012-01-05 18:39 ` [PATCH 1/2] brcmf: " Stephen Hemminger
[not found] ` <20120105184000.572918423@vyatta.com>
2012-01-05 19:12 ` Arend van Spriel [this message]
2012-01-05 19:15 ` [PATCH 2/2] brcmfmac: use existing net_device_stats Stephen Hemminger
2012-01-05 19:39 ` Franky Lin
2012-01-06 5:00 ` Stephen Hemminger
2012-01-06 20:07 ` Franky Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F05F60C.5030406@broadcom.com \
--to=arend@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.