All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Kucheria <amit.kucheria@linaro.org>
To: Mike Turquette <mturquette@linaro.org>
Cc: linux@arm.linux.org.uk, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	jeremy.kerr@canonical.com, paul@pwsan.com,
	broonie@opensource.wolfsonmicro.com, tglx@linutronix.de,
	linus.walleij@stericsson.com, dsaxena@linaro.org,
	patches@linaro.org, linaro-dev@lists.linaro.org,
	grant.likely@secretlab.ca, sboyd@quicinc.com,
	shawn.guo@freescale.com, skannan@quicinc.com,
	magnus.damm@gmail.com, arnd.bergmann@linaro.org,
	eric.miao@linaro.org, richard.zhao@linaro.org, mturquette@ti.com,
	andrew@lunn.ch
Subject: Re: [PATCH v4 2/6] Documentation: common clk API
Date: Thu, 5 Jan 2012 16:31:05 +0200	[thread overview]
Message-ID: <20120105143105.GA2865@matterhorn1> (raw)
In-Reply-To: <1323834838-2206-3-git-send-email-mturquette@linaro.org>

Tiny, tiny typo...

On 11 Dec 13, Mike Turquette wrote:

> +clk_set_rate deserves a special mention because it is more complex than
> +the other operations.  There are three key concepts to the common
> +clk_set_rate implementation:
> +
> +1) recursively traversing up the clk tree and changing clk rates, one
> +parent at a time, if each clk allows it
> +2) failing to change rate if the clk is enabled and must only change
> +rates while disabled
> +3) using clk rate change notifiers to allow devices to handle dynamic
> +rate changes for clks which do support changing rates while enabled
> +
> +For the simple, non-recursive case the call graph looks like:
> +
> +clk_set_rate(clk, rate);
> +	__clk_set_rate(clk, rate);
> +		clk->round_rate(clk, rate *parent_rate);
                                      ^^^^^^^^

need a comma here? The next sentence kept me busy for 5 mins.

> +		clk->set_rate(clk, rate);
> +
> +You might be wondering what that third paramater in .round_rate is.  If
> +a clk supports the CLK_PARENT_SET_RATE flag then that enables it's
> +hardware-specific .round_rate function to provide a new rate that the
> +parent should transition to.  For example, imagine a rate-adjustable clk
> +A that is the parent of clk B, which has a fixed divider of 2.

WARNING: multiple messages have this Message-ID (diff)
From: amit.kucheria@linaro.org (Amit Kucheria)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/6] Documentation: common clk API
Date: Thu, 5 Jan 2012 16:31:05 +0200	[thread overview]
Message-ID: <20120105143105.GA2865@matterhorn1> (raw)
In-Reply-To: <1323834838-2206-3-git-send-email-mturquette@linaro.org>

Tiny, tiny typo...

On 11 Dec 13, Mike Turquette wrote:

> +clk_set_rate deserves a special mention because it is more complex than
> +the other operations.  There are three key concepts to the common
> +clk_set_rate implementation:
> +
> +1) recursively traversing up the clk tree and changing clk rates, one
> +parent at a time, if each clk allows it
> +2) failing to change rate if the clk is enabled and must only change
> +rates while disabled
> +3) using clk rate change notifiers to allow devices to handle dynamic
> +rate changes for clks which do support changing rates while enabled
> +
> +For the simple, non-recursive case the call graph looks like:
> +
> +clk_set_rate(clk, rate);
> +	__clk_set_rate(clk, rate);
> +		clk->round_rate(clk, rate *parent_rate);
                                      ^^^^^^^^

need a comma here? The next sentence kept me busy for 5 mins.

> +		clk->set_rate(clk, rate);
> +
> +You might be wondering what that third paramater in .round_rate is.  If
> +a clk supports the CLK_PARENT_SET_RATE flag then that enables it's
> +hardware-specific .round_rate function to provide a new rate that the
> +parent should transition to.  For example, imagine a rate-adjustable clk
> +A that is the parent of clk B, which has a fixed divider of 2.

  reply	other threads:[~2012-01-05 14:31 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-14  3:53 [PATCH v4 0/6] common clk framework Mike Turquette
2011-12-14  3:53 ` Mike Turquette
2011-12-14  3:53 ` Mike Turquette
     [not found] ` <1323834838-2206-1-git-send-email-mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-12-14  3:53   ` [PATCH v4 1/6] clk: Kconfig: add entry for HAVE_CLK_PREPARE Mike Turquette
2011-12-14  3:53     ` Mike Turquette
2011-12-14  3:53     ` Mike Turquette
2011-12-14  3:53   ` [PATCH v4 2/6] Documentation: common clk API Mike Turquette
2011-12-14  3:53     ` Mike Turquette
2011-12-14  3:53     ` Mike Turquette
2012-01-05 14:31     ` Amit Kucheria [this message]
2012-01-05 14:31       ` Amit Kucheria
2012-01-05 20:04       ` Turquette, Mike
2012-01-05 20:04         ` Turquette, Mike
2012-01-05 20:04         ` Turquette, Mike
2011-12-14  3:53   ` [PATCH v4 3/6] clk: introduce the common clock framework Mike Turquette
2011-12-14  3:53     ` Mike Turquette
2011-12-14  3:53     ` Mike Turquette
2011-12-14  4:52     ` Ryan Mallon
2011-12-14  4:52       ` Ryan Mallon
     [not found]       ` <4EE82B76.2000204-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-14 19:07         ` Turquette, Mike
2011-12-14 19:07           ` Turquette, Mike
2011-12-14 19:07           ` Turquette, Mike
2011-12-14  7:50     ` Richard Zhao
2011-12-14  7:50       ` Richard Zhao
2011-12-14  7:50       ` Richard Zhao
2011-12-14 13:18     ` Thomas Gleixner
2011-12-14 13:18       ` Thomas Gleixner
2011-12-17  0:45       ` Turquette, Mike
2011-12-17  0:45         ` Turquette, Mike
2011-12-17  0:45         ` Turquette, Mike
2011-12-17 11:04         ` Russell King - ARM Linux
2011-12-17 11:04           ` Russell King - ARM Linux
2011-12-17 11:04           ` Russell King - ARM Linux
2012-01-14  4:18           ` Saravana Kannan
2012-01-14  4:18             ` Saravana Kannan
     [not found]             ` <4F11021A.8070407-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2012-01-14  4:39               ` Turquette, Mike
2012-01-14  4:39                 ` Turquette, Mike
2012-01-14  4:39                 ` Turquette, Mike
2012-01-14  4:51                 ` Saravana Kannan
2012-01-14  4:51                   ` Saravana Kannan
     [not found]         ` <CAJOA=zO=gM2r4pCVo+orLqE9Q1SSw4h5nXsAHo-e_SHZAfvKDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-04  2:15           ` Richard Zhao
2012-01-04  2:15             ` Richard Zhao
2012-01-04  2:15             ` Richard Zhao
2012-01-04 14:32             ` Rob Herring
2012-01-04 14:32               ` Rob Herring
     [not found]               ` <4F0462FF.1000308-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-05  1:01                 ` Turquette, Mike
2012-01-05  1:01                   ` Turquette, Mike
2012-01-05  1:01                   ` Turquette, Mike
2012-01-05  1:23                   ` Richard Zhao
2012-01-05  1:23                     ` Richard Zhao
2012-01-05  1:23                     ` Richard Zhao
2012-01-05  2:11                   ` Rob Herring
2012-01-05  2:11                     ` Rob Herring
2012-01-05  4:07                     ` Turquette, Mike
2012-01-05  4:07                       ` Turquette, Mike
2012-01-05  4:07                       ` Turquette, Mike
     [not found]                       ` <CAJOA=zPgwiOSoyZK1SpzZVZfTOmwruTR=WO+gRdVZrZVzNuPSA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-12 13:13                         ` Amit Kucheria
2012-01-12 13:13                           ` Amit Kucheria
2012-01-12 13:13                           ` Amit Kucheria
2012-01-13  0:04                       ` Saravana Kannan
2012-01-13  0:04                         ` Saravana Kannan
2012-01-13  0:48                         ` Rob Herring
2012-01-13  0:48                           ` Rob Herring
2012-01-13  1:19                           ` Saravana Kannan
2012-01-13  1:19                             ` Saravana Kannan
     [not found]                         ` <4F0F7507.3080501-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2012-01-13 14:53                           ` Shawn Guo
2012-01-13 14:53                             ` Shawn Guo
2012-01-13 14:53                             ` Shawn Guo
2011-12-14  3:53   ` [PATCH v4 4/6] clk: introduce rate change notifiers Mike Turquette
2011-12-14  3:53     ` Mike Turquette
2011-12-14  3:53     ` Mike Turquette
2011-12-14  3:53   ` [PATCH v4 5/6] clk: basic gateable and fixed-rate clks Mike Turquette
2011-12-14  3:53     ` Mike Turquette
2011-12-14  3:53     ` Mike Turquette
2011-12-14  5:15     ` Ryan Mallon
2011-12-14  5:15       ` Ryan Mallon
     [not found]       ` <4EE830D5.5070305-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-17  0:57         ` Turquette, Mike
2011-12-17  0:57           ` Turquette, Mike
2011-12-17  0:57           ` Turquette, Mike
2011-12-14  3:53   ` [PATCH v4 6/6] clk: export the clk tree topology to debugfs Mike Turquette
2011-12-14  3:53     ` Mike Turquette
2011-12-14  3:53     ` Mike Turquette
2011-12-14  4:02 ` [PATCH v4 0/6] common clk framework Turquette, Mike
2011-12-14  4:02   ` Turquette, Mike
2011-12-14  4:02   ` Turquette, Mike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120105143105.GA2865@matterhorn1 \
    --to=amit.kucheria@linaro.org \
    --cc=andrew@lunn.ch \
    --cc=arnd.bergmann@linaro.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dsaxena@linaro.org \
    --cc=eric.miao@linaro.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jeremy.kerr@canonical.com \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=mturquette@linaro.org \
    --cc=mturquette@ti.com \
    --cc=patches@linaro.org \
    --cc=paul@pwsan.com \
    --cc=richard.zhao@linaro.org \
    --cc=sboyd@quicinc.com \
    --cc=shawn.guo@freescale.com \
    --cc=skannan@quicinc.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.