From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg KH <greg@kroah.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [patch -longterm v2] V4L/DVB: v4l2-ioctl: integer overflow in
Date: Thu, 05 Jan 2012 17:56:20 +0000 [thread overview]
Message-ID: <20120105175620.GB3644@mwanda> (raw)
In-Reply-To: <20120105164358.GA26153@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
On Thu, Jan 05, 2012 at 08:43:58AM -0800, Greg KH wrote:
> On Thu, Jan 05, 2012 at 09:28:22AM +0300, Dan Carpenter wrote:
> > If p->count is too high the multiplication could overflow and
> > array_size would be lower than expected. Mauro and Hans Verkuil
> > suggested that we cap it at 1024. That comes from the maximum
> > number of controls with lots of room for expantion.
> >
> > $ grep V4L2_CID include/linux/videodev2.h | wc -l
> > 211
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> So this patch is only for 2.6.32? But the original needs to get into
> Linus's tree first (which is what I'm guessing the other patch you sent
> is, right?)
Yep.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg KH <greg@kroah.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [patch -longterm v2] V4L/DVB: v4l2-ioctl: integer overflow in video_usercopy()
Date: Thu, 5 Jan 2012 20:56:20 +0300 [thread overview]
Message-ID: <20120105175620.GB3644@mwanda> (raw)
In-Reply-To: <20120105164358.GA26153@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
On Thu, Jan 05, 2012 at 08:43:58AM -0800, Greg KH wrote:
> On Thu, Jan 05, 2012 at 09:28:22AM +0300, Dan Carpenter wrote:
> > If p->count is too high the multiplication could overflow and
> > array_size would be lower than expected. Mauro and Hans Verkuil
> > suggested that we cap it at 1024. That comes from the maximum
> > number of controls with lots of room for expantion.
> >
> > $ grep V4L2_CID include/linux/videodev2.h | wc -l
> > 211
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> So this patch is only for 2.6.32? But the original needs to get into
> Linus's tree first (which is what I'm guessing the other patch you sent
> is, right?)
Yep.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-05 17:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 6:34 [patch -longterm] V4L/DVB: v4l2-ioctl: integer overflow in Dan Carpenter
2011-12-15 6:34 ` [patch -longterm] V4L/DVB: v4l2-ioctl: integer overflow in video_usercopy() Dan Carpenter
2011-12-15 9:21 ` Mauro Carvalho Chehab
2011-12-15 9:21 ` Mauro Carvalho Chehab
2011-12-15 9:33 ` Hans Verkuil
2011-12-15 9:33 ` Hans Verkuil
2011-12-15 9:50 ` Mauro Carvalho Chehab
2011-12-15 9:50 ` Mauro Carvalho Chehab
2012-01-03 20:55 ` [patch -longterm] V4L/DVB: v4l2-ioctl: integer overflow in Greg KH
2012-01-03 20:55 ` [patch -longterm] V4L/DVB: v4l2-ioctl: integer overflow in video_usercopy() Greg KH
2012-01-04 13:35 ` [patch -longterm] V4L/DVB: v4l2-ioctl: integer overflow in Dan Carpenter
2012-01-04 13:35 ` [patch -longterm] V4L/DVB: v4l2-ioctl: integer overflow in video_usercopy() Dan Carpenter
2012-01-05 6:27 ` [patch -next] V4L/DVB: v4l2-ioctl: integer overflow in Dan Carpenter
2012-01-05 6:27 ` [patch -next] V4L/DVB: v4l2-ioctl: integer overflow in video_usercopy() Dan Carpenter
2012-01-05 6:28 ` [patch -longterm v2] V4L/DVB: v4l2-ioctl: integer overflow in Dan Carpenter
2012-01-05 6:28 ` [patch -longterm v2] V4L/DVB: v4l2-ioctl: integer overflow in video_usercopy() Dan Carpenter
2012-01-05 16:43 ` [patch -longterm v2] V4L/DVB: v4l2-ioctl: integer overflow in Greg KH
2012-01-05 16:43 ` [patch -longterm v2] V4L/DVB: v4l2-ioctl: integer overflow in video_usercopy() Greg KH
2012-01-05 17:56 ` Dan Carpenter [this message]
2012-01-05 17:56 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105175620.GB3644@mwanda \
--to=dan.carpenter@oracle.com \
--cc=greg@kroah.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.