All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] iw: use a newer commit in the public git
@ 2012-01-05  9:47 Eyal Reizer
  2012-01-05  9:58 ` Paul Menzel
  0 siblings, 1 reply; 3+ messages in thread
From: Eyal Reizer @ 2012-01-05  9:47 UTC (permalink / raw)
  To: openembedded-devel

switch to use a newer commit in the public git

Signed-off-by: Eyal Reizer <eyalr@ti.com>
---
 recipes/iw/iw_git.bb |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/recipes/iw/iw_git.bb b/recipes/iw/iw_git.bb
index c98e1bc..f0dc7ff 100644
--- a/recipes/iw/iw_git.bb
+++ b/recipes/iw/iw_git.bb
@@ -4,9 +4,9 @@ SECTION = "base"
 PRIORITY = "optional"
 LICENSE = "BSD"
 
-SRCREV = "0a236ef5f8e4ba7218aac7d0cdacf45673d5b35c"
-PR = "r0"
-PV = "0.9.22"
+SRCREV = "8b2b1c6a77ee17e4128b22845cb8c5901de296c9"
+PR = "r1"
+PV = "3.2"
 PR_append = "+gitr${SRCPV}"
 
 DEPENDS = "libnl pkgconfig"
-- 
1.7.0.4




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] iw: use a newer commit in the public git
  2012-01-05  9:47 [PATCH] iw: use a newer commit in the public git Eyal Reizer
@ 2012-01-05  9:58 ` Paul Menzel
  2012-01-05 18:36   ` Denys Dmytriyenko
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Menzel @ 2012-01-05  9:58 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]

Dear Ayal,


Am Donnerstag, den 05.01.2012, 11:47 +0200 schrieb Eyal Reizer:
> switch to use a newer commit in the public git

That line is redundant to the commit summary. Why not use the following
as the summary?

        iw_git: Update to commit 8b2b1c6a (version 3.2)

Additionally please add if this just introduces new features or if it
fixes any problems for you.

And lastly please add how you have tested the new version.

> Signed-off-by: Eyal Reizer <eyalr@ti.com>
> ---
>  recipes/iw/iw_git.bb |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/recipes/iw/iw_git.bb b/recipes/iw/iw_git.bb
> index c98e1bc..f0dc7ff 100644
> --- a/recipes/iw/iw_git.bb
> +++ b/recipes/iw/iw_git.bb
> @@ -4,9 +4,9 @@ SECTION = "base"
>  PRIORITY = "optional"
>  LICENSE = "BSD"
>  
> -SRCREV = "0a236ef5f8e4ba7218aac7d0cdacf45673d5b35c"
> -PR = "r0"
> -PV = "0.9.22"
> +SRCREV = "8b2b1c6a77ee17e4128b22845cb8c5901de296c9"
> +PR = "r1"
> +PV = "3.2"
>  PR_append = "+gitr${SRCPV}"

I always forget, if a `PR` bump for a version update is needed if we
have `PR_append${SRCPV}`. Could you check that again, please.
 
>  DEPENDS = "libnl pkgconfig"


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iw: use a newer commit in the public git
  2012-01-05  9:58 ` Paul Menzel
@ 2012-01-05 18:36   ` Denys Dmytriyenko
  0 siblings, 0 replies; 3+ messages in thread
From: Denys Dmytriyenko @ 2012-01-05 18:36 UTC (permalink / raw)
  To: openembedded-devel

On Thu, Jan 05, 2012 at 10:58:26AM +0100, Paul Menzel wrote:
> Dear Ayal,
> 
> 
> Am Donnerstag, den 05.01.2012, 11:47 +0200 schrieb Eyal Reizer:
> > switch to use a newer commit in the public git
> 
> That line is redundant to the commit summary. Why not use the following
> as the summary?
> 
>         iw_git: Update to commit 8b2b1c6a (version 3.2)
> 
> Additionally please add if this just introduces new features or if it
> fixes any problems for you.
> 
> And lastly please add how you have tested the new version.
> 
> > Signed-off-by: Eyal Reizer <eyalr@ti.com>
> > ---
> >  recipes/iw/iw_git.bb |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/recipes/iw/iw_git.bb b/recipes/iw/iw_git.bb
> > index c98e1bc..f0dc7ff 100644
> > --- a/recipes/iw/iw_git.bb
> > +++ b/recipes/iw/iw_git.bb
> > @@ -4,9 +4,9 @@ SECTION = "base"
> >  PRIORITY = "optional"
> >  LICENSE = "BSD"
> >  
> > -SRCREV = "0a236ef5f8e4ba7218aac7d0cdacf45673d5b35c"
> > -PR = "r0"
> > -PV = "0.9.22"
> > +SRCREV = "8b2b1c6a77ee17e4128b22845cb8c5901de296c9"
> > +PR = "r1"
> > +PV = "3.2"
> >  PR_append = "+gitr${SRCPV}"
> 
> I always forget, if a `PR` bump for a version update is needed if we
> have `PR_append${SRCPV}`. Could you check that again, please.

Actually, if the version (PV) is bumped, PR should go back to 0 or 1, ideally. 
Otherwise it's not needed to bump PR, when PV is increased.

-- 
Denys



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-01-05 18:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-05  9:47 [PATCH] iw: use a newer commit in the public git Eyal Reizer
2012-01-05  9:58 ` Paul Menzel
2012-01-05 18:36   ` Denys Dmytriyenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.