From: "Henrik Rydberg" <rydberg@euromail.se>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Chase Douglas <chase.douglas@canonical.com>
Subject: Re: [PATCH v2] Input: evdev - Add EVIOC mechanism to extract the MT slot state
Date: Fri, 6 Jan 2012 20:18:35 +0100 [thread overview]
Message-ID: <20120106191835.GA2998@polaris.bitmath.org> (raw)
In-Reply-To: <20120106185544.GB2795@polaris.bitmath.org>
On Fri, Jan 06, 2012 at 07:55:44PM +0100, Henrik Rydberg wrote:
> > 2 different processes should be fine; the problem would be if 2 threads
> > of the same process share the same file descriptor. So far the rest of
> > evdev copes just fine with multiple threads using the same fd (all
> > operations are atomic in this regard), setting ABS_MT_SLOT before
> > fetching the state break this property.
>
> Are we talking about the need for a per-client mutex, or something
> more subtle, like introducing indirect coupling between threads
> through per-client states? The former ought to be easily remedied.
Ok, maybe not to so easy after all, which probably answers my own
question. Looks like a EVIOCGMTSLOT, taking both slot and event code
as argument, would be the cleaner route to take. Another ioctl, how do we
feel about that?
Henrik
next prev parent reply other threads:[~2012-01-06 19:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 15:16 [PATCH v2] Input: evdev - Add EVIOC mechanism to extract the MT slot state Henrik Rydberg
2012-01-06 16:25 ` Chase Douglas
2012-01-06 18:00 ` Benjamin Tissoires
2012-01-06 18:00 ` Benjamin Tissoires
2012-01-06 18:18 ` Dmitry Torokhov
2012-01-06 18:55 ` Henrik Rydberg
2012-01-06 19:18 ` Henrik Rydberg [this message]
2012-01-06 19:34 ` Chase Douglas
2012-01-06 19:48 ` Henrik Rydberg
2012-01-06 20:02 ` Dmitry Torokhov
2012-01-06 20:14 ` Henrik Rydberg
2012-01-06 20:23 ` Dmitry Torokhov
2012-01-06 20:30 ` Henrik Rydberg
2012-01-06 20:03 ` Dmitry Torokhov
2012-01-06 18:56 ` Chase Douglas
2012-01-06 19:58 ` Dmitry Torokhov
2012-01-06 20:09 ` Chase Douglas
2012-01-06 20:17 ` Dmitry Torokhov
2012-01-06 20:44 ` Chase Douglas
2012-01-06 18:45 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120106191835.GA2998@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=benjamin.tissoires@gmail.com \
--cc=chase.douglas@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.