From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: David Brown <davidb@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: MSM's mach/system.h
Date: Sat, 7 Jan 2012 10:59:51 +0000 [thread overview]
Message-ID: <20120107105950.GD13857@n2100.arm.linux.org.uk> (raw)
Guys,
MSM's mach/system.h is now almost empty, except for this:
extern void (*msm_hw_reset_hook)(void);
Grepping around for this, I find only one place where it's called, and
nowhere it's set:
$ grep -r msm_hw_reset_hook arch/arm/*msm* drivers/
arch/arm/mach-msm/include/mach/system.h:extern void (*msm_hw_reset_hook)(void);
arch/arm/mach-msm/smd.c:void (*msm_hw_reset_hook)(void);
arch/arm/mach-msm/smd.c: if (msm_hw_reset_hook)
arch/arm/mach-msm/smd.c: msm_hw_reset_hook();
As we've virtually eliminated the mach/system.h include (the only
remaining ones apart from this are the three unconverted platforms for
the restart changes), can this declaration move to somewhere else, or
can this read-only hook be removed?
Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: MSM's mach/system.h
Date: Sat, 7 Jan 2012 10:59:51 +0000 [thread overview]
Message-ID: <20120107105950.GD13857@n2100.arm.linux.org.uk> (raw)
Guys,
MSM's mach/system.h is now almost empty, except for this:
extern void (*msm_hw_reset_hook)(void);
Grepping around for this, I find only one place where it's called, and
nowhere it's set:
$ grep -r msm_hw_reset_hook arch/arm/*msm* drivers/
arch/arm/mach-msm/include/mach/system.h:extern void (*msm_hw_reset_hook)(void);
arch/arm/mach-msm/smd.c:void (*msm_hw_reset_hook)(void);
arch/arm/mach-msm/smd.c: if (msm_hw_reset_hook)
arch/arm/mach-msm/smd.c: msm_hw_reset_hook();
As we've virtually eliminated the mach/system.h include (the only
remaining ones apart from this are the three unconverted platforms for
the restart changes), can this declaration move to somewhere else, or
can this read-only hook be removed?
Thanks.
next reply other threads:[~2012-01-07 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 10:59 Russell King - ARM Linux [this message]
2012-01-07 10:59 ` MSM's mach/system.h Russell King - ARM Linux
2012-01-07 19:08 ` David Brown
2012-01-07 19:08 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120107105950.GD13857@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.