[lm-sensors] [PATCH 01/17 v2] hwmon: (ad7414) fix checkpath issues

[lm-sensors] [PATCH 01/17 v2] hwmon: (ad7414) fix checkpath issues

[Frans Meulenbroeks]

fixed:
WARNING: simple_strtol is obsolete, use kstrtol instead
#133: FILE: ad7414.c:133:
+	long temp = simple_strtol(buf, NULL, 10);

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
---
 drivers/hwmon/ad7414.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/hwmon/ad7414.c b/drivers/hwmon/ad7414.c
index df29a7f..7c4939a 100644
--- a/drivers/hwmon/ad7414.c
+++ b/drivers/hwmon/ad7414.c
@@ -130,7 +130,11 @@ static ssize_t set_max_min(struct device *dev,
 	struct ad7414_data *data = i2c_get_clientdata(client);
 	int index = to_sensor_dev_attr(attr)->index;
 	u8 reg = AD7414_REG_LIMIT[index];
-	long temp = simple_strtol(buf, NULL, 10);
+	long temp;
+	int ret = kstrtol(buf, 10, &temp);
+
+	if (ret < 0)
+		return ret;
 
 	temp = SENSORS_LIMIT(temp, -40000, 85000);
 	temp = (temp + (temp < 0 ? -500 : 500)) / 1000;
-- 
1.7.8.2


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 01/17 v2] hwmon: (ad7414) fix checkpath

[Guenter Roeck]

On Sun, Jan 08, 2012 at 01:34:04PM -0500, Frans Meulenbroeks wrote:
> fixed:
> WARNING: simple_strtol is obsolete, use kstrtol instead
> #133: FILE: ad7414.c:133:
> +	long temp = simple_strtol(buf, NULL, 10);
> 
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>

Series looks good.

Jean, do you want to take any of those ? Otherwise I'll apply the entire series
for one of the rc candidates, together with Frans' earlier patches.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 01/17 v2] hwmon: (ad7414) fix checkpath

[Jean Delvare]

On Sun, 8 Jan 2012 11:06:33 -0800, Guenter Roeck wrote:
> On Sun, Jan 08, 2012 at 01:34:04PM -0500, Frans Meulenbroeks wrote:
> > fixed:
> > WARNING: simple_strtol is obsolete, use kstrtol instead
> > #133: FILE: ad7414.c:133:
> > +	long temp = simple_strtol(buf, NULL, 10);
> > 
> > Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
> 
> Series looks good.
> 
> Jean, do you want to take any of those ? Otherwise I'll apply the entire series
> for one of the rc candidates, together with Frans' earlier patches.

Please take them all, my hwmon patch queue for kernel 3.3 is almost
empty so risks of collisions are limited.

Thanks,
-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 01/17 v2] hwmon: (ad7414) fix checkpath

[Guenter Roeck]

On Sun, Jan 08, 2012 at 02:25:47PM -0500, Jean Delvare wrote:
> On Sun, 8 Jan 2012 11:06:33 -0800, Guenter Roeck wrote:
> > On Sun, Jan 08, 2012 at 01:34:04PM -0500, Frans Meulenbroeks wrote:
> > > fixed:
> > > WARNING: simple_strtol is obsolete, use kstrtol instead
> > > #133: FILE: ad7414.c:133:
> > > +	long temp = simple_strtol(buf, NULL, 10);
> > > 
> > > Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
> > 
> > Series looks good.
> > 
> > Jean, do you want to take any of those ? Otherwise I'll apply the entire series
> > for one of the rc candidates, together with Frans' earlier patches.
> 
> Please take them all, my hwmon patch queue for kernel 3.3 is almost
> empty so risks of collisions are limited.
> 
Ok.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors