From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Patrick Lai <plai@codeaurora.org>,
alsa-devel@alsa-project.org, lrg@ti.com
Subject: Re: [PATCH] ASoC: introduce SOC_SINGLE_S8_TLV macro
Date: Mon, 9 Jan 2012 00:28:09 -0800 [thread overview]
Message-ID: <20120109082808.GJ22134@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F0AA37F.5050602@metafoo.de>
On Mon, Jan 09, 2012 at 09:21:19AM +0100, Lars-Peter Clausen wrote:
> On 01/08/2012 09:23 PM, Mark Brown wrote:
> > Since no shifts are specified the signature is just the same as your
> > SOC_SINGLE_S8_TLV:
> There is a shift, but it is hard coded to 8 in snd_soc_get_volsw_s8, which
> isn't considered by the patch currently. So either SOC_DOUBLE_S8_TLV should
> initialize rshift to 8 or a shift and rshift parameter should be added. It
The second option seems better here.
> might also makes sense to add a shift parameter to SOC_SINGLE_S8_TLV as well.
Probably.
prev parent reply other threads:[~2012-01-09 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-08 1:53 [PATCH] ASoC: introduce SOC_SINGLE_S8_TLV macro Patrick Lai
2012-01-08 20:23 ` Mark Brown
2012-01-09 5:52 ` Patrick Lai
2012-01-09 6:26 ` Mark Brown
2012-01-09 8:21 ` Lars-Peter Clausen
2012-01-09 8:28 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120109082808.GJ22134@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=lrg@ti.com \
--cc=plai@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.