All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Lai <plai@codeaurora.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, lrg@ti.com
Subject: Re: [PATCH] ASoC: introduce SOC_SINGLE_S8_TLV macro
Date: Sun, 08 Jan 2012 21:52:17 -0800	[thread overview]
Message-ID: <4F0A8091.8050804@codeaurora.org> (raw)
In-Reply-To: <20120108202332.GE29065@opensource.wolfsonmicro.com>

> | #define SOC_DOUBLE_S8_TLV(xname, xreg, xmin, xmax, tlv_array) \
>
> Since no shifts are specified the signature is just the same as your
> SOC_SINGLE_S8_TLV:

Yes, it could have been made more generic with shift parameter.
Existing behavior is writing same value to most and least significant
bytes of 16-bit wide register.

>> +#define SOC_SINGLE_S8_TLV(xname, xreg, xmin, xmax, tlv_array) \
>
> so it looks like what really ought to happen here is that the existing
> macro gets renamed to the new macro and a new macro gets defined for
> double values if one is needed.

Is there backward compatibility concern? I see soc/codec/uda1380.c
already using SOC_DOUBLE_S8_TLV.

Thanks
Patrick

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
---

  reply	other threads:[~2012-01-09  5:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-08  1:53 [PATCH] ASoC: introduce SOC_SINGLE_S8_TLV macro Patrick Lai
2012-01-08 20:23 ` Mark Brown
2012-01-09  5:52   ` Patrick Lai [this message]
2012-01-09  6:26     ` Mark Brown
2012-01-09  8:21   ` Lars-Peter Clausen
2012-01-09  8:28     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0A8091.8050804@codeaurora.org \
    --to=plai@codeaurora.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.