* [patch] dmatest: store correct thread count in dmatest_add_channel()
@ 2011-11-24 11:47 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2011-11-24 11:47 UTC (permalink / raw)
To: Vinod Koul; +Cc: Dan Williams, linux-kernel, kernel-janitors
The original code added 1 to the thread_count, but the intent was to
add += cnt.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index 2b8661b..24225f0 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -599,7 +599,7 @@ static int dmatest_add_channel(struct dma_chan *chan)
}
if (dma_has_cap(DMA_PQ, dma_dev->cap_mask)) {
cnt = dmatest_add_threads(dtc, DMA_PQ);
- thread_count += cnt > 0 ?: 0;
+ thread_count += cnt > 0 ? cnt : 0;
}
pr_info("dmatest: Started %u threads using %s\n",
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] dmatest: store correct thread count in dmatest_add_channel()
@ 2011-11-24 11:47 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2011-11-24 11:47 UTC (permalink / raw)
To: Vinod Koul; +Cc: Dan Williams, linux-kernel, kernel-janitors
The original code added 1 to the thread_count, but the intent was to
add += cnt.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index 2b8661b..24225f0 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -599,7 +599,7 @@ static int dmatest_add_channel(struct dma_chan *chan)
}
if (dma_has_cap(DMA_PQ, dma_dev->cap_mask)) {
cnt = dmatest_add_threads(dtc, DMA_PQ);
- thread_count += cnt > 0 ?: 0;
+ thread_count += cnt > 0 ? cnt : 0;
}
pr_info("dmatest: Started %u threads using %s\n",
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch] dmatest: store correct thread count in
2011-11-24 11:47 ` Dan Carpenter
@ 2012-01-09 11:17 ` Dan Carpenter
-1 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2012-01-09 11:17 UTC (permalink / raw)
To: Vinod Koul; +Cc: Dan Williams, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
Ping?
regards,
dan carpenter
On Thu, Nov 24, 2011 at 02:47:34PM +0300, Dan Carpenter wrote:
> The original code added 1 to the thread_count, but the intent was to
> add += cnt.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index 2b8661b..24225f0 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -599,7 +599,7 @@ static int dmatest_add_channel(struct dma_chan *chan)
> }
> if (dma_has_cap(DMA_PQ, dma_dev->cap_mask)) {
> cnt = dmatest_add_threads(dtc, DMA_PQ);
> - thread_count += cnt > 0 ?: 0;
> + thread_count += cnt > 0 ? cnt : 0;
> }
>
> pr_info("dmatest: Started %u threads using %s\n",
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] dmatest: store correct thread count in dmatest_add_channel()
@ 2012-01-09 11:17 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2012-01-09 11:17 UTC (permalink / raw)
To: Vinod Koul; +Cc: Dan Williams, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
Ping?
regards,
dan carpenter
On Thu, Nov 24, 2011 at 02:47:34PM +0300, Dan Carpenter wrote:
> The original code added 1 to the thread_count, but the intent was to
> add += cnt.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index 2b8661b..24225f0 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -599,7 +599,7 @@ static int dmatest_add_channel(struct dma_chan *chan)
> }
> if (dma_has_cap(DMA_PQ, dma_dev->cap_mask)) {
> cnt = dmatest_add_threads(dtc, DMA_PQ);
> - thread_count += cnt > 0 ?: 0;
> + thread_count += cnt > 0 ? cnt : 0;
> }
>
> pr_info("dmatest: Started %u threads using %s\n",
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] dmatest: store correct thread count in dmatest_add_channel()
2012-01-09 11:17 ` [patch] dmatest: store correct thread count in dmatest_add_channel() Dan Carpenter
@ 2012-01-10 7:53 ` Dan Williams
-1 siblings, 0 replies; 6+ messages in thread
From: Dan Williams @ 2012-01-10 7:53 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Vinod Koul, linux-kernel, kernel-janitors
On Mon, Jan 9, 2012 at 3:17 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Ping?
>
> regards,
> dan carpenter
Just a comedy of delay, on my part, in getting this patch merged. In
fact there is this fix that pre-dates yours:
http://marc.info/?l=linux-kernel&m\x131388785009475&w=2
I'll push this along.
Thanks for the nudge,
Dan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] dmatest: store correct thread count in dmatest_add_channel()
@ 2012-01-10 7:53 ` Dan Williams
0 siblings, 0 replies; 6+ messages in thread
From: Dan Williams @ 2012-01-10 7:53 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Vinod Koul, linux-kernel, kernel-janitors
On Mon, Jan 9, 2012 at 3:17 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Ping?
>
> regards,
> dan carpenter
Just a comedy of delay, on my part, in getting this patch merged. In
fact there is this fix that pre-dates yours:
http://marc.info/?l=linux-kernel&m=131388785009475&w=2
I'll push this along.
Thanks for the nudge,
Dan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-01-10 7:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-24 11:47 [patch] dmatest: store correct thread count in dmatest_add_channel() Dan Carpenter
2011-11-24 11:47 ` Dan Carpenter
2012-01-09 11:17 ` [patch] dmatest: store correct thread count in Dan Carpenter
2012-01-09 11:17 ` [patch] dmatest: store correct thread count in dmatest_add_channel() Dan Carpenter
2012-01-10 7:53 ` Dan Williams
2012-01-10 7:53 ` Dan Williams
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.