From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux-mm <linux-mm@kvack.org>, Andi Kleen <andi@firstfloor.org>,
Christoph Hellwig <hch@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Roland McGrath <roland@hack.frob.com>,
Thomas Gleixner <tglx@linutronix.de>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Anton Arapov <anton@redhat.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Jim Keniston <jkenisto@linux.vnet.ibm.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
yrl.pp-manager.tt@hitachi.com
Subject: Re: [PATCH v8 3.2.0-rc5 9/9] perf: perf interface for uprobes
Date: Mon, 9 Jan 2012 16:54:27 +0530 [thread overview]
Message-ID: <20120109112427.GB10189@linux.vnet.ibm.com> (raw)
In-Reply-To: <4F06D22D.9060906@hitachi.com>
>
> > +
> > +static int convert_to_perf_probe_point(struct probe_trace_point *tp,
> > + struct perf_probe_point *pp)
> > +{
> > + pp->function = strdup(tp->symbol);
> > + if (pp->function == NULL)
> > + return -ENOMEM;
> > + pp->offset = tp->offset;
> > + pp->retprobe = tp->retprobe;
> > +
> > + return 0;
> > +}
>
> This function could be used in kprobe_convert_to_perf_probe() too.
> In that case, it will be separated as a cleanup from this.
Do you really want this in a separate patch, since it doesnt make too
much sense without the uprobes code.
--
Thanks and Regards
Srikar
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux-mm <linux-mm@kvack.org>, Andi Kleen <andi@firstfloor.org>,
Christoph Hellwig <hch@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Roland McGrath <roland@hack.frob.com>,
Thomas Gleixner <tglx@linutronix.de>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Anton Arapov <anton@redhat.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Jim Keniston <jkenisto@linux.vnet.ibm.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
yrl.pp-manager.tt@hitachi.com
Subject: Re: [PATCH v8 3.2.0-rc5 9/9] perf: perf interface for uprobes
Date: Mon, 9 Jan 2012 16:54:27 +0530 [thread overview]
Message-ID: <20120109112427.GB10189@linux.vnet.ibm.com> (raw)
In-Reply-To: <4F06D22D.9060906@hitachi.com>
>
> > +
> > +static int convert_to_perf_probe_point(struct probe_trace_point *tp,
> > + struct perf_probe_point *pp)
> > +{
> > + pp->function = strdup(tp->symbol);
> > + if (pp->function == NULL)
> > + return -ENOMEM;
> > + pp->offset = tp->offset;
> > + pp->retprobe = tp->retprobe;
> > +
> > + return 0;
> > +}
>
> This function could be used in kprobe_convert_to_perf_probe() too.
> In that case, it will be separated as a cleanup from this.
Do you really want this in a separate patch, since it doesnt make too
much sense without the uprobes code.
--
Thanks and Regards
Srikar
next prev parent reply other threads:[~2012-01-09 11:32 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 12:27 [PATCH v8 3.2.0-rc5 0/9] uprobes patchset Srikar Dronamraju
2011-12-16 12:27 ` Srikar Dronamraju
2011-12-16 12:28 ` [PATCH v8 3.2.0-rc5 1/9] uprobes: Install and remove breakpoints Srikar Dronamraju
2011-12-16 12:28 ` Srikar Dronamraju
2012-01-04 16:49 ` Peter Zijlstra
2012-01-04 16:49 ` Peter Zijlstra
2012-01-06 6:14 ` Srikar Dronamraju
2012-01-06 6:14 ` Srikar Dronamraju
2012-01-06 10:57 ` Peter Zijlstra
2012-01-06 10:57 ` Peter Zijlstra
2012-01-06 11:08 ` Srikar Dronamraju
2012-01-06 11:08 ` Srikar Dronamraju
2012-01-04 16:51 ` Peter Zijlstra
2012-01-04 16:51 ` Peter Zijlstra
2012-01-04 17:12 ` Steven Rostedt
2012-01-04 17:12 ` Steven Rostedt
2011-12-16 12:28 ` [PATCH v8 3.2.0-rc5 2/9] uprobes: handle breakpoint and signal step exception Srikar Dronamraju
2011-12-16 12:28 ` Srikar Dronamraju
2011-12-16 12:28 ` [PATCH v8 3.2.0-rc5 3/9] uprobes: slot allocation Srikar Dronamraju
2011-12-16 12:28 ` Srikar Dronamraju
2011-12-16 12:28 ` [PATCH v8 3.2.0-rc5 4/9] uprobes: counter to optimize probe hits Srikar Dronamraju
2011-12-16 12:28 ` Srikar Dronamraju
2011-12-16 12:28 ` [PATCH v8 3.2.0-rc5 5/9] tracing: modify is_delete, is_return from ints to bool Srikar Dronamraju
2011-12-16 12:28 ` Srikar Dronamraju
2011-12-16 12:29 ` [PATCH v8 3.2.0-rc5 6/9] tracing: Extract out common code for kprobes/uprobes traceevents Srikar Dronamraju
2011-12-16 12:29 ` Srikar Dronamraju
2011-12-16 12:29 ` [PATCH v8 3.2.0-rc5 7/9] tracing: uprobes trace_event interface Srikar Dronamraju
2011-12-16 12:29 ` Srikar Dronamraju
2011-12-16 12:29 ` [PATCH v8 3.2.0-rc5 8/9] perf: rename target_module to target Srikar Dronamraju
2011-12-16 12:29 ` Srikar Dronamraju
2011-12-16 12:29 ` [PATCH v8 3.2.0-rc5 9/9] perf: perf interface for uprobes Srikar Dronamraju
2011-12-16 12:29 ` Srikar Dronamraju
2012-01-06 10:51 ` Masami Hiramatsu
2012-01-06 10:51 ` Masami Hiramatsu
2012-01-09 11:22 ` Srikar Dronamraju
2012-01-09 11:22 ` Srikar Dronamraju
2012-01-13 1:56 ` Masami Hiramatsu
2012-01-13 1:56 ` Masami Hiramatsu
2012-01-13 5:14 ` Srikar Dronamraju
2012-01-13 5:14 ` Srikar Dronamraju
2012-01-13 14:02 ` Masami Hiramatsu
2012-01-13 14:02 ` Masami Hiramatsu
2012-01-16 14:21 ` [PATCH v9 3.2 " Srikar Dronamraju
2012-01-16 14:21 ` Srikar Dronamraju
2012-01-09 11:24 ` Srikar Dronamraju [this message]
2012-01-09 11:24 ` [PATCH v8 3.2.0-rc5 " Srikar Dronamraju
2012-01-12 14:50 ` Masami Hiramatsu
2012-01-12 14:50 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120109112427.GB10189@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=acme@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=andi@firstfloor.org \
--cc=anton@redhat.com \
--cc=hch@infradead.org \
--cc=jkenisto@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=roland@hack.frob.com \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.