All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Antti Palosaari <crope@iki.fi>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
	linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] af9013: change & to &&
Date: Mon, 09 Jan 2012 17:48:17 +0000	[thread overview]
Message-ID: <20120109174817.GH3731@mwanda> (raw)
In-Reply-To: <4F0B26A1.2020402@iki.fi>

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

On Mon, Jan 09, 2012 at 07:40:49PM +0200, Antti Palosaari wrote:
> Clear bug, I will test it later when applied to master if not
> already. Thanks!

You're welcome, but it's not a bug because (1 & 1 & 0) is the same
as (1 && 1 && 0) but if one of them wasn't a bool it would be a
problem.  The other difference between & and && is that && has
orderring guarantees but that's also not a factor here.

regards,
dan carpenter


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Antti Palosaari <crope@iki.fi>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
	linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] af9013: change & to &&
Date: Mon, 9 Jan 2012 20:48:17 +0300	[thread overview]
Message-ID: <20120109174817.GH3731@mwanda> (raw)
In-Reply-To: <4F0B26A1.2020402@iki.fi>

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

On Mon, Jan 09, 2012 at 07:40:49PM +0200, Antti Palosaari wrote:
> Clear bug, I will test it later when applied to master if not
> already. Thanks!

You're welcome, but it's not a bug because (1 & 1 & 0) is the same
as (1 && 1 && 0) but if one of them wasn't a bool it would be a
problem.  The other difference between & and && is that && has
orderring guarantees but that's also not a factor here.

regards,
dan carpenter


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-01-09 17:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-05  6:23 [patch] [media] af9013: change & to && Dan Carpenter
2012-01-05  6:23 ` Dan Carpenter
2012-01-09 17:40 ` Antti Palosaari
2012-01-09 17:40   ` Antti Palosaari
2012-01-09 17:48   ` Dan Carpenter [this message]
2012-01-09 17:48     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120109174817.GH3731@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=crope@iki.fi \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.