From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kevin Hilman <khilman@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>,
linux-omap@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCHv8 4/5] twl4030: add support for external voltage get/set
Date: Tue, 10 Jan 2012 03:30:12 +0000 [thread overview]
Message-ID: <20120110033012.GM30766@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <871ur8weds.fsf@ti.com>
On Mon, Jan 09, 2012 at 05:11:11PM -0800, Kevin Hilman wrote:
> Seems to me like the get/set override should be more generic (part of
> regulator core) instead of TWL specific?
> Otherwise, whenever someone hooks up a non-TWL regulator to an OMAP and
> is using HW control (via VC/VP), they'll have to duplicate all of this
> stuff in their regulator driver?
Frankly I'm not sure I understand how the hardware is supposed to work
here - originally the plan was to just add a new regulator driver for
the hardware control block which is I guess clean enough but it seems
like some of the other control still goes via the normal path.
next prev parent reply other threads:[~2012-01-10 3:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 15:29 [PATCHv8 0/5] SMPS regulator driver Tero Kristo
2011-12-09 15:29 ` [PATCHv8 1/5] TEMP: OMAP3: beagle rev-c4: enable OPP6 Tero Kristo
2011-12-09 15:29 ` [PATCHv8 2/5] omap3: voltage: fix channel configuration Tero Kristo
2011-12-10 0:21 ` Kevin Hilman
2011-12-12 9:34 ` Tero Kristo
2011-12-12 15:02 ` Kevin Hilman
2011-12-09 15:29 ` [PATCHv8 3/5] omap3: add common twl configurations for vdd1 and vdd2 Tero Kristo
2011-12-09 15:29 ` [PATCHv8 4/5] twl4030: add support for external voltage get/set Tero Kristo
2011-12-19 8:33 ` Samuel Ortiz
2011-12-19 9:56 ` Girdwood, Liam
2011-12-20 0:31 ` Mark Brown
[not found] ` <87hb04wesx.fsf@ti.com>
2012-01-10 8:05 ` Tero Kristo
2012-01-10 1:11 ` Kevin Hilman
2012-01-10 3:30 ` Mark Brown [this message]
2012-01-10 15:19 ` Kevin Hilman
2012-01-10 19:10 ` Mark Brown
2012-02-14 12:47 ` Tero Kristo
2012-02-14 19:16 ` Kevin Hilman
2012-02-15 8:38 ` Tero Kristo
2011-12-09 15:29 ` [PATCHv8 5/5] omap3: twl: add external controllers for core voltage regulators Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110033012.GM30766@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.