Re: [PATCHv8 4/5] twl4030: add support for external voltage get/set

[Kevin Hilman <khilman@ti.com>]

Tero Kristo <t-kristo@ti.com> writes:

> On Tue, 2012-01-10 at 19:10 +0000, Mark Brown wrote:
>> On Tue, Jan 10, 2012 at 07:19:18AM -0800, Kevin Hilman wrote:
>> 
>> > Yes, some of the control still goes via the normal path (although I
>> > forget which, maybe Benoit can remind us), so I think it's best to add
>> > the HW control part to each regulator that might uses it.
>> 
>> > Ideally this could be facilitated by adding the extentions to the
>> > regulator core so the amount of code needed for each regulator driver
>> > would be minimal.
>> 
>> I think the original version of the patch was something along those
>> lines but it was just a general facility which ignored the regulator
>> driver entirely which didn't feel well integrated.  The discussion
>> suggested that this wasn't something that'd work with other regulators
>> so a per-driver solution seemed OK.
>
> Coming back to this patch now as I have time to look at it, what is the
> general opinion, is it acceptable to patch the regulator core to add
> support for the external controller or should I just resend the latest
> version with changes Mark suggested? This will probably mean that once
> we add new regulator drivers (e.g. pmics) we may need to duplicate the
> external controller support here.

How about you keep it in the regulator driver for now, and when we need
to abstract it out, we make the case for it then.

Kevin