From: Mel Gorman <mgorman@suse.de>
To: Hillf Danton <dhillf@gmail.com>
Cc: linux-mm@kvack.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: vmscan: fix setting reclaim mode
Date: Tue, 10 Jan 2012 09:44:52 +0000 [thread overview]
Message-ID: <20120110094452.GC4118@suse.de> (raw)
In-Reply-To: <CAJd=RBAqzawZ=jEFt7TrZgU0gaejMkfiBxzH7Y19qqNnsZrJGw@mail.gmail.com>
On Sun, Jan 08, 2012 at 03:05:03PM +0800, Hillf Danton wrote:
> The check for under memory pressure is corrected, then lumpy reclaim or
> reclaim/compaction could be avoided either when for order-O reclaim or
> when free pages are already low enough.
>
No explanation of problem, how this patch fixes it or what the impact
is.
At a glance, this will have the impact of using sync reclaim at low
reclaim priorities. This is unexpected so needs much better explanation.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Hillf Danton <dhillf@gmail.com>
Cc: linux-mm@kvack.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: vmscan: fix setting reclaim mode
Date: Tue, 10 Jan 2012 09:44:52 +0000 [thread overview]
Message-ID: <20120110094452.GC4118@suse.de> (raw)
In-Reply-To: <CAJd=RBAqzawZ=jEFt7TrZgU0gaejMkfiBxzH7Y19qqNnsZrJGw@mail.gmail.com>
On Sun, Jan 08, 2012 at 03:05:03PM +0800, Hillf Danton wrote:
> The check for under memory pressure is corrected, then lumpy reclaim or
> reclaim/compaction could be avoided either when for order-O reclaim or
> when free pages are already low enough.
>
No explanation of problem, how this patch fixes it or what the impact
is.
At a glance, this will have the impact of using sync reclaim at low
reclaim priorities. This is unexpected so needs much better explanation.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2012-01-10 9:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-08 7:05 [PATCH] mm: vmscan: fix setting reclaim mode Hillf Danton
2012-01-08 7:05 ` Hillf Danton
2012-01-10 9:44 ` Mel Gorman [this message]
2012-01-10 9:44 ` Mel Gorman
2012-01-10 15:58 ` Hillf Danton
2012-01-10 15:58 ` Hillf Danton
2012-01-10 16:44 ` Mel Gorman
2012-01-10 16:44 ` Mel Gorman
2012-01-10 16:58 ` Hillf Danton
2012-01-10 16:58 ` Hillf Danton
2012-01-11 12:12 ` Hillf Danton
2012-01-11 12:12 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110094452.GC4118@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dhillf@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.