From: Stephen Hemminger <shemminger@vyatta.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Kay Sievers <kay.sievers@vrfy.org>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] vhost-net: add module alias
Date: Wed, 11 Jan 2012 08:58:57 -0800 [thread overview]
Message-ID: <20120111085857.0753322f@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <4F0D3543.7020401@msgid.tls.msk.ru>
On Wed, 11 Jan 2012 11:07:47 +0400
Michael Tokarev <mjt@tls.msk.ru> wrote:
> On 11.01.2012 08:54, Stephen Hemminger wrote:
> > By adding the a module alias, programs (or users) won't have to explicitly
> > call modprobe. Vhost-net will always be available if built into the kernel.
> > It does require assigning a permanent minor number for depmod to work.
> > Choose one next to TUN since this driver is related to it.
>
> Why do you think a statically-allocated device number will do any good
> at all? Static /dev is gone almost completely, at least on the systems
> where whole virt stuff makes any sense, so you don't have pre-created
> vhost-net device anymore, and hence this allocation makes no sense.
> Just IMHO anyway.
The statically allocated device number is required for the udev/module
autoloading to work. Probably the udev infrastructure needs a consistent
number to hang off of.
It looks like:
* driver adds MODULE_ALIAS() for devname and character device
* depmod scans modules and creates modules.devname (in /lib/modules)
* udev uses modules.devname to autoload the module
$ /sbin/modinfo vhost_net
filename: /lib/modules/3.2.0-net+/kernel/drivers/vhost/vhost_net.ko
alias: devname:vhost-net
alias: char-major-10-201
description: Host kernel accelerator for virtio net
...
See also: https://lkml.org/lkml/2010/5/21/134
next prev parent reply other threads:[~2012-01-11 16:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 4:54 [PATCH] vhost-net: add module alias Stephen Hemminger
2012-01-11 7:07 ` Michael Tokarev
2012-01-11 16:58 ` Stephen Hemminger [this message]
2012-01-11 17:02 ` Michael Tokarev
2012-01-11 17:02 ` Michael Tokarev
2012-01-11 17:03 ` Kay Sievers
2012-01-11 17:03 ` Kay Sievers
2012-01-11 7:07 ` Michael Tokarev
2012-01-11 7:43 ` Amos Kong
2012-01-11 16:54 ` Stephen Hemminger
2012-01-11 16:54 ` Stephen Hemminger
2012-01-11 18:15 ` Michael S. Tsirkin
2012-01-11 17:16 ` [PATCH] vhost-net: add module alias (v2) Stephen Hemminger
2012-01-11 18:09 ` Michael S. Tsirkin
2012-01-11 21:00 ` Ben Hutchings
2012-01-12 2:15 ` Zhi Yong Wu
2012-01-12 5:30 ` [PATCH] vhost-net: add module alias (v2.1) Stephen Hemminger
2012-01-13 4:07 ` David Miller
2012-01-13 4:19 ` Kay Sievers
2012-01-13 18:12 ` David Miller
2012-01-15 12:42 ` Michael S. Tsirkin
2012-01-15 12:42 ` Michael S. Tsirkin
2012-01-16 12:26 ` Alan Cox
2012-01-16 15:52 ` Stephen Hemminger
2012-01-16 23:06 ` David Miller
2012-01-16 23:34 ` Alan Cox
2012-01-12 2:15 ` [PATCH] vhost-net: add module alias (v2) Zhi Yong Wu
2012-01-12 20:04 ` Thadeu Lima de Souza Cascardo
2012-01-12 20:04 ` Thadeu Lima de Souza Cascardo
2012-01-16 12:28 ` [PATCH] vhost-net: add module alias Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111085857.0753322f@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=kay.sievers@vrfy.org \
--cc=kvm@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.