All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Stephen Hemminger <shemminger@vyatta.com>, Alan Cox <device@lanana.org>
Cc: netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Kay Sievers <kay.sievers@vrfy.org>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [PATCH] vhost-net: add module alias (v2)
Date: Wed, 11 Jan 2012 09:16:53 -0800	[thread overview]
Message-ID: <20120111091653.188b24ab@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20120110205400.6c1cb306@nehalam.linuxnetplumber.net>

By adding the correct module alias, programs won't have to explicitly
call modprobe. Vhost-net will always be available if built into the kernel.
It does require assigning a permanent minor number for depmod to work.
Choose one next to TUN since this driver is related to it.

Also, use C99 style initialization.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

---
v2 - document minor number and make sure to not overlap

 Documentation/devices.txt  |    2 ++
 drivers/vhost/net.c        |    8 +++++---
 include/linux/miscdevice.h |    1 +
 3 files changed, 8 insertions(+), 3 deletions(-)

--- a/drivers/vhost/net.c	2012-01-10 10:56:58.883179194 -0800
+++ b/drivers/vhost/net.c	2012-01-10 19:48:23.650225892 -0800
@@ -856,9 +856,9 @@ static const struct file_operations vhos
 };
 
 static struct miscdevice vhost_net_misc = {
-	MISC_DYNAMIC_MINOR,
-	"vhost-net",
-	&vhost_net_fops,
+	.minor = VHOST_NET_MINOR,
+	.name = "vhost-net",
+	.fops = &vhost_net_fops,
 };
 
 static int vhost_net_init(void)
@@ -879,3 +879,5 @@ MODULE_VERSION("0.0.1");
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Michael S. Tsirkin");
 MODULE_DESCRIPTION("Host kernel accelerator for virtio net");
+MODULE_ALIAS_MISCDEV(VHOST_NET_MINOR);
+MODULE_ALIAS("devname:vhost-net");
--- a/include/linux/miscdevice.h	2012-01-10 10:56:59.779189436 -0800
+++ b/include/linux/miscdevice.h	2012-01-11 09:13:20.803694316 -0800
@@ -42,6 +42,7 @@
 #define AUTOFS_MINOR		235
 #define MAPPER_CTRL_MINOR	236
 #define LOOP_CTRL_MINOR		237
+#define VHOST_NET_MINOR		238
 #define MISC_DYNAMIC_MINOR	255
 
 struct device;
--- a/Documentation/devices.txt	2012-01-10 10:56:53.399116518 -0800
+++ b/Documentation/devices.txt	2012-01-11 09:12:49.251197653 -0800
@@ -447,6 +447,8 @@ Your cooperation is appreciated.
 		234 = /dev/btrfs-control	Btrfs control device
 		235 = /dev/autofs	Autofs control device
 		236 = /dev/mapper/control	Device-Mapper control device
+		237 = /dev/vhost-net	Host kernel accelerator for virtio net
+
 		240-254			Reserved for local use
 		255			Reserved for MISC_DYNAMIC_MINOR

  parent reply	other threads:[~2012-01-11 17:16 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11  4:54 [PATCH] vhost-net: add module alias Stephen Hemminger
2012-01-11  7:07 ` Michael Tokarev
2012-01-11 16:58   ` Stephen Hemminger
2012-01-11 17:02     ` Michael Tokarev
2012-01-11 17:02     ` Michael Tokarev
2012-01-11 17:03     ` Kay Sievers
2012-01-11 17:03     ` Kay Sievers
2012-01-11  7:07 ` Michael Tokarev
2012-01-11  7:43 ` Amos Kong
2012-01-11 16:54   ` Stephen Hemminger
2012-01-11 18:15     ` Michael S. Tsirkin
2012-01-11 16:54   ` Stephen Hemminger
2012-01-11 17:16 ` Stephen Hemminger [this message]
2012-01-11 18:09   ` [PATCH] vhost-net: add module alias (v2) Michael S. Tsirkin
2012-01-11 21:00   ` Ben Hutchings
2012-01-12  2:15   ` Zhi Yong Wu
2012-01-12  5:30     ` [PATCH] vhost-net: add module alias (v2.1) Stephen Hemminger
2012-01-13  4:07       ` David Miller
2012-01-13  4:19         ` Kay Sievers
2012-01-13 18:12           ` David Miller
2012-01-15 12:42         ` Michael S. Tsirkin
2012-01-15 12:42         ` Michael S. Tsirkin
2012-01-16 12:26           ` Alan Cox
2012-01-16 15:52             ` Stephen Hemminger
2012-01-16 23:06               ` David Miller
2012-01-16 23:34               ` Alan Cox
2012-01-12  2:15   ` [PATCH] vhost-net: add module alias (v2) Zhi Yong Wu
2012-01-12 20:04   ` Thadeu Lima de Souza Cascardo
2012-01-12 20:04   ` Thadeu Lima de Souza Cascardo
2012-01-16 12:28 ` [PATCH] vhost-net: add module alias Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120111091653.188b24ab@nehalam.linuxnetplumber.net \
    --to=shemminger@vyatta.com \
    --cc=device@lanana.org \
    --cc=kay.sievers@vrfy.org \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.