From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@oss.sgi.com, Michael Lueck <mlueck@lueckdatasystems.com>
Subject: Re: Why does xfsdump encounter "WARNING: could not get list of non-root attributes for nondir ino nnnn: Cannot allocate memory (12)"?
Date: Wed, 11 Jan 2012 04:55:14 -0500 [thread overview]
Message-ID: <20120111095513.GA26958@infradead.org> (raw)
In-Reply-To: <20120102213706.GQ23662@dastard>
On Tue, Jan 03, 2012 at 08:37:06AM +1100, Dave Chinner wrote:
> xfs: handle kmalloc failure when reading attrs
>
> From: Dave Chinner <dchinner@redhat.com>
>
> xfsdump uses for a large buffer for extended attributes, which has a
> kmalloc'd shadow buffer in the kernel. This can fail after the
> system has been running for some time as it is a high order
> allocation. Convert this to a vmalloc so that it doesn't require
> contiguous memory and so won't randomly fail while xfsdump is
> running.
I think this should use kmalloc for allocation smaller than a page to
avoid the vmalloc overhead for the usual case of small attributes.
Also the fs/xattr.c code for the normal xattr system calls needs the
same treatment.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-01-11 9:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-31 21:50 Why does xfsdump encounter "WARNING: could not get list of non-root attributes for nondir ino nnnn: Cannot allocate memory (12)"? Michael Lueck
2012-01-02 21:37 ` Dave Chinner
2012-01-03 3:24 ` Michael Lueck
2012-01-11 9:55 ` Christoph Hellwig [this message]
2012-01-11 10:03 ` Dave Chinner
2012-01-11 10:04 ` Christoph Hellwig
2012-01-11 10:14 ` Dave Chinner
2012-01-11 10:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111095513.GA26958@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@oss.sgi.com \
--cc=mlueck@lueckdatasystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.