From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@oss.sgi.com, Michael Lueck <mlueck@lueckdatasystems.com>
Subject: Re: Why does xfsdump encounter "WARNING: could not get list of non-root attributes for nondir ino nnnn: Cannot allocate memory (12)"?
Date: Wed, 11 Jan 2012 21:14:27 +1100 [thread overview]
Message-ID: <20120111101426.GI24410@dastard> (raw)
In-Reply-To: <20120111100412.GA1538@infradead.org>
On Wed, Jan 11, 2012 at 05:04:12AM -0500, Christoph Hellwig wrote:
> On Wed, Jan 11, 2012 at 09:03:16PM +1100, Dave Chinner wrote:
> > Sounds like a generic kvmalloc()/kvfree() call pair is the answer
> > then. i.e. if kmalloc fails, then use vmalloc()...
>
> If my memory serves me right that's been discussed and rejected a few
> times before.
Which has lead to several implementations of duplicated
functionality like:
- ext4_kvmalloc/ext4_kvfree
- drm_malloc_ab/drm_calloc_large/drm_free_large
- ceph_buffer_new/ceph_buffer_release
- gfs2_alloc_sort_buffer/gfs2_free_sort_buffer
- __ntfs_malloc/ntfs_free
I don't think adding another two sets of identical wrappers (or open
coding it) is the right thing given that it is a repeating pattern.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-01-11 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-31 21:50 Why does xfsdump encounter "WARNING: could not get list of non-root attributes for nondir ino nnnn: Cannot allocate memory (12)"? Michael Lueck
2012-01-02 21:37 ` Dave Chinner
2012-01-03 3:24 ` Michael Lueck
2012-01-11 9:55 ` Christoph Hellwig
2012-01-11 10:03 ` Dave Chinner
2012-01-11 10:04 ` Christoph Hellwig
2012-01-11 10:14 ` Dave Chinner [this message]
2012-01-11 10:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111101426.GI24410@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@oss.sgi.com \
--cc=mlueck@lueckdatasystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.