From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] video: s3c-fb: Add device tree support
Date: Wed, 11 Jan 2012 17:40:48 +0000 [thread overview]
Message-ID: <20120111174048.GC24213@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAJuYYwRSO9OuiLNddOa+KLSkGwOAp3yHcrQZXSk_k2+oxtEDPQ@mail.gmail.com>
On Wed, Jan 11, 2012 at 04:34:28PM +0530, Thomas Abraham wrote:
> On 10 January 2012 10:22, Mark Brown
> > This isn't terribly informative for the user - which GPIOs and in what
> > order are they specified? Looking at the code it looks like pin mux
> > configuration so just some wording saying it's a list of pins to be used
> > for the framebuffer function.
> Ok. I will modify the sentence to mean that it is list of gpios used
> by framebuffer controller for data/timing interface with the lcd
> panel. Thanks for your review.
You probably want to mention that it's for pin muxing, the reason I
didn't get what it meant on first read was that normally GPIO means
specifically the sort of stuff handled by gpiolib.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: linux-fbdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
kgene.kim@samsung.com, FlorianSchandinat@gmx.de,
jg1.han@samsung.com, rob.herring@calxeda.com,
grant.likely@secretlab.ca, linux-samsung-soc@vger.kernel.org,
patches@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] video: s3c-fb: Add device tree support
Date: Wed, 11 Jan 2012 17:40:48 +0000 [thread overview]
Message-ID: <20120111174048.GC24213@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAJuYYwRSO9OuiLNddOa+KLSkGwOAp3yHcrQZXSk_k2+oxtEDPQ@mail.gmail.com>
On Wed, Jan 11, 2012 at 04:34:28PM +0530, Thomas Abraham wrote:
> On 10 January 2012 10:22, Mark Brown
> > This isn't terribly informative for the user - which GPIOs and in what
> > order are they specified? Looking at the code it looks like pin mux
> > configuration so just some wording saying it's a list of pins to be used
> > for the framebuffer function.
> Ok. I will modify the sentence to mean that it is list of gpios used
> by framebuffer controller for data/timing interface with the lcd
> panel. Thanks for your review.
You probably want to mention that it's for pin muxing, the reason I
didn't get what it meant on first read was that normally GPIO means
specifically the sort of stuff handled by gpiolib.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] video: s3c-fb: Add device tree support
Date: Wed, 11 Jan 2012 17:40:48 +0000 [thread overview]
Message-ID: <20120111174048.GC24213@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAJuYYwRSO9OuiLNddOa+KLSkGwOAp3yHcrQZXSk_k2+oxtEDPQ@mail.gmail.com>
On Wed, Jan 11, 2012 at 04:34:28PM +0530, Thomas Abraham wrote:
> On 10 January 2012 10:22, Mark Brown
> > This isn't terribly informative for the user - which GPIOs and in what
> > order are they specified? ?Looking at the code it looks like pin mux
> > configuration so just some wording saying it's a list of pins to be used
> > for the framebuffer function.
> Ok. I will modify the sentence to mean that it is list of gpios used
> by framebuffer controller for data/timing interface with the lcd
> panel. Thanks for your review.
You probably want to mention that it's for pin muxing, the reason I
didn't get what it meant on first read was that normally GPIO means
specifically the sort of stuff handled by gpiolib.
next prev parent reply other threads:[~2012-01-11 17:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 19:59 [PATCH] video: s3c-fb: Add device tree support Thomas Abraham
2012-01-09 20:01 ` Thomas Abraham
2012-01-09 20:01 ` Thomas Abraham
2012-01-10 4:52 ` Mark Brown
2012-01-10 4:52 ` Mark Brown
2012-01-10 4:52 ` Mark Brown
[not found] ` <20120110045219.GA5433-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-01-11 11:04 ` Thomas Abraham
2012-01-11 11:16 ` Thomas Abraham
2012-01-11 11:04 ` Thomas Abraham
2012-01-11 17:40 ` Mark Brown [this message]
2012-01-11 17:40 ` Mark Brown
2012-01-11 17:40 ` Mark Brown
2012-01-11 9:16 ` Jingoo Han
2012-01-11 9:16 ` Jingoo Han
2012-01-11 9:16 ` Jingoo Han
2012-01-11 11:11 ` Thomas Abraham
2012-01-11 11:23 ` Thomas Abraham
2012-01-11 11:11 ` Thomas Abraham
2012-01-13 21:03 ` Sylwester Nawrocki
2012-01-13 21:03 ` Sylwester Nawrocki
2012-01-13 21:03 ` Sylwester Nawrocki
2012-01-13 21:30 ` Sylwester Nawrocki
2012-01-13 21:30 ` Sylwester Nawrocki
2012-01-13 21:30 ` Sylwester Nawrocki
2012-01-17 5:14 ` Thomas Abraham
2012-01-17 5:26 ` Thomas Abraham
2012-01-17 5:14 ` Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111174048.GC24213@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.