Re: [PATCH 1/2] ecryptfs: Improve metatdata read failure logging

[Kees Cook <keescook@chromium.org>]

On Wed, Jan 11, 2012 at 06:00:41PM +0100, Tim Gardner wrote:
> There are 3 read failure cases in ecryptfs_read_metadata(), but only 2
> of them are uniquely noted by kernel log messages. This patch
> identifies and logs each read failure case. It also correctly interprets
> a negative return value from ecryptfs_read_lower().
> 
> Removes unnecessary variable initialization.
> 
> Cc: linux-kernel@vger.kernel.org
> Cc: stable@vger.kernel.org
> Cc: Tyler Hicks <tyler.hicks@canonical.com>
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>

I always like more verbose error reporting. :)

Reviewed-by: Kees Cook <keescook@chromium.org>

> +		printk(KERN_ERR "%s: Could not read %u bytes\n",
> +			__func__, crypt_stat->extent_size);

I wonder if eCryptfs in general might want to consider using the "pr_fmt"
and "pr_*" macros to do printk handling:

#define pr_fmt(fmt) __func__ ": " fmt

...

	pr_err("Could not read %u bytes\n", crypt_stat->extent_size);


-Kees

-- 
Kees Cook