From: Stephen Hemminger <shemminger@vyatta.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH] net: reintroduce missing rcu_assign_pointer() calls
Date: Thu, 12 Jan 2012 07:47:51 -0800 [thread overview]
Message-ID: <20120112074751.7c870323@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1326379292.2950.22.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
On Thu, 12 Jan 2012 15:41:32 +0100
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> commit a9b3cd7f32 (rcu: convert uses of rcu_assign_pointer(x, NULL) to
> RCU_INIT_POINTER) did a lot of incorrect changes, since it did a
> complete conversion of rcu_assign_pointer(x, y) to RCU_INIT_POINTER(x,
> y).
>
Agreed. Looks like the script was too aggressive.
next prev parent reply other threads:[~2012-01-12 15:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 13:56 [BUG] commit a9b3cd7f32 is a mess Eric Dumazet
2012-01-12 14:41 ` [PATCH] net: reintroduce missing rcu_assign_pointer() calls Eric Dumazet
2012-01-12 15:47 ` Stephen Hemminger [this message]
2012-01-12 20:27 ` David Miller
2012-01-12 17:12 ` [BUG] commit a9b3cd7f32 is a mess Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120112074751.7c870323@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.