From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [BUG] commit a9b3cd7f32 is a mess
Date: Thu, 12 Jan 2012 09:12:01 -0800 [thread overview]
Message-ID: <20120112171201.GC2419@linux.vnet.ibm.com> (raw)
In-Reply-To: <1326376603.2950.14.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
On Thu, Jan 12, 2012 at 02:56:43PM +0100, Eric Dumazet wrote:
> commit a9b3cd7f32 (rcu: convert uses of rcu_assign_pointer(x, NULL) to
> RCU_INIT_POINTER) is complete garbage.
>
> Real content of this commit doesnt reflect Changelog claim.
>
> I found this while trying to understand a 3.2 regression in IGMP code.
>
> iml->sfmode = MCAST_EXCLUDE;
> - rcu_assign_pointer(inet->mc_list, iml);
> + RCU_INIT_POINTER(inet->mc_list, iml);
>
> Obviously iml is not NULL here.
>
> Please Paul dont Ack a patch only reading the Changelog.
Sigh. That will teach me to trust coccinelle. :-(
> I'll make a patch to revert all non NULL uses.
Please accept my apologies. I will avoid trusting coccinelle quite so
much in the future, and thank you for fixing this up.
Thanx, Paul
prev parent reply other threads:[~2012-01-12 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 13:56 [BUG] commit a9b3cd7f32 is a mess Eric Dumazet
2012-01-12 14:41 ` [PATCH] net: reintroduce missing rcu_assign_pointer() calls Eric Dumazet
2012-01-12 15:47 ` Stephen Hemminger
2012-01-12 20:27 ` David Miller
2012-01-12 17:12 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120112171201.GC2419@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.