From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Mel Gorman <mgorman@suse.de>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH] mm: __count_immobile_pages make sure the node is online
Date: Thu, 12 Jan 2012 13:26:29 -0800 [thread overview]
Message-ID: <20120112132629.345e0e37.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120112123555.GF1042@tiehlicka.suse.cz>
On Thu, 12 Jan 2012 13:35:55 +0100
Michal Hocko <mhocko@suse.cz> wrote:
> On Thu 12-01-12 11:14:15, Mel Gorman wrote:
> > On Thu, Jan 12, 2012 at 11:05:21AM +0100, Michal Hocko wrote:
>
> > Be aware that this is not the version picked up by Andrew. It would
> > not hurt to resend as V2 with a changelog and a note saying it replaces
> > mm-fix-null-ptr-dereference-in-__count_immobile_pages.patch in mmotm.
They're rather different things? According to the changelogs,
mm-fix-null-ptr-dereference-in-__count_immobile_pages.patch fixes a
known-to-occur oops.
mm-__count_immobile_pages-make-sure-the-node-is-online.patch fixes a
bug which might happen in the future if we change the node_zones layut?
So I'm thinking that
mm-fix-null-ptr-dereference-in-__count_immobile_pages.patch is 3.3 and
-stable material, whereas this patch
(mm-__count_immobile_pages-make-sure-the-node-is-online.patch) is 3.3
material. (Actually, it's 3.4 material which I shall stuff into 3.3
because the amount of MM material which we're putting into 3.3 is just
off the charts and I fear that 3.4 will be similar)
> > This is just in case the wrong one gets merged due to this thread
> > getting lost in the noise of Andrew's inbox.
It won't get lost, but there's a higher-than-usual chance of delays if
the patch happens during the merge window: if I see a lengthy patch
thread I'll move it into my to-apply folder for consideration later on.
So I will look at it, but it might be after the merge window. We can
still apply a fix after the merge window of course, but this all might
end up leaving buggy code in the tree for longer than we'd like.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Mel Gorman <mgorman@suse.de>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH] mm: __count_immobile_pages make sure the node is online
Date: Thu, 12 Jan 2012 13:26:29 -0800 [thread overview]
Message-ID: <20120112132629.345e0e37.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120112123555.GF1042@tiehlicka.suse.cz>
On Thu, 12 Jan 2012 13:35:55 +0100
Michal Hocko <mhocko@suse.cz> wrote:
> On Thu 12-01-12 11:14:15, Mel Gorman wrote:
> > On Thu, Jan 12, 2012 at 11:05:21AM +0100, Michal Hocko wrote:
>
> > Be aware that this is not the version picked up by Andrew. It would
> > not hurt to resend as V2 with a changelog and a note saying it replaces
> > mm-fix-null-ptr-dereference-in-__count_immobile_pages.patch in mmotm.
They're rather different things? According to the changelogs,
mm-fix-null-ptr-dereference-in-__count_immobile_pages.patch fixes a
known-to-occur oops.
mm-__count_immobile_pages-make-sure-the-node-is-online.patch fixes a
bug which might happen in the future if we change the node_zones layut?
So I'm thinking that
mm-fix-null-ptr-dereference-in-__count_immobile_pages.patch is 3.3 and
-stable material, whereas this patch
(mm-__count_immobile_pages-make-sure-the-node-is-online.patch) is 3.3
material. (Actually, it's 3.4 material which I shall stuff into 3.3
because the amount of MM material which we're putting into 3.3 is just
off the charts and I fear that 3.4 will be similar)
> > This is just in case the wrong one gets merged due to this thread
> > getting lost in the noise of Andrew's inbox.
It won't get lost, but there's a higher-than-usual chance of delays if
the patch happens during the merge window: if I see a lengthy patch
thread I'll move it into my to-apply folder for consideration later on.
So I will look at it, but it might be after the merge window. We can
still apply a fix after the merge window of course, but this all might
end up leaving buggy code in the tree for longer than we'd like.
next prev parent reply other threads:[~2012-01-12 21:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 16:30 [PATCH] mm: Fix NULL ptr dereference in __count_immobile_pages Michal Hocko
2012-01-10 16:30 ` Michal Hocko
2012-01-10 21:31 ` David Rientjes
2012-01-10 21:31 ` David Rientjes
2012-01-11 8:48 ` Michal Hocko
2012-01-11 8:48 ` Michal Hocko
2012-01-12 2:17 ` KAMEZAWA Hiroyuki
2012-01-12 2:17 ` KAMEZAWA Hiroyuki
2012-01-12 8:27 ` Michal Hocko
2012-01-12 8:27 ` Michal Hocko
2012-01-12 8:35 ` KAMEZAWA Hiroyuki
2012-01-12 8:35 ` KAMEZAWA Hiroyuki
2012-01-12 9:23 ` Michal Hocko
2012-01-12 9:23 ` Michal Hocko
2012-01-12 9:33 ` KAMEZAWA Hiroyuki
2012-01-12 9:33 ` KAMEZAWA Hiroyuki
2012-01-12 10:05 ` [PATCH] mm: __count_immobile_pages make sure the node is online Michal Hocko
2012-01-12 10:05 ` Michal Hocko
2012-01-12 11:14 ` Mel Gorman
2012-01-12 11:14 ` Mel Gorman
2012-01-12 12:35 ` Michal Hocko
2012-01-12 12:35 ` Michal Hocko
2012-01-12 21:26 ` Andrew Morton [this message]
2012-01-12 21:26 ` Andrew Morton
2012-01-12 21:39 ` Michal Hocko
2012-01-12 21:39 ` Michal Hocko
2012-01-13 10:04 ` Mel Gorman
2012-01-13 10:04 ` Mel Gorman
2012-01-11 22:34 ` [PATCH] mm: Fix NULL ptr dereference in __count_immobile_pages Andrew Morton
2012-01-11 22:34 ` Andrew Morton
2012-01-12 8:21 ` Michal Hocko
2012-01-12 8:21 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120112132629.345e0e37.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.