From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: Mandeep Singh Baines <msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Theodore Tso <tytso-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>,
Paul Taysom <taysom-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Paul Taysom <taysom-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Olof Johansson <olofj-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
Andrew Morton <akpm-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Alexander Viro
<viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] fs: Fix mod_timer crash when removing USB sticks
Date: Thu, 12 Jan 2012 15:23:03 -0800 [thread overview]
Message-ID: <20120112152303.420e723e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120112223544.GC18166-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
On Thu, 12 Jan 2012 14:35:44 -0800
Mandeep Singh Baines <msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote:
> Theodore Tso (tytso-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org) wrote:
> > On Thu, Jan 12, 2012 at 4:53 PM, Mandeep Singh Baines <msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>wrote:
> >
> > >
> > > Hi Greg,
> > >
> > > What is the conventional way of doing this? There is a lot of good
> > > data in the bug report which might be useful to reviewers. We
> > > couldn't find a de-facto way of referencing the downstream bug database
> > > so we just made up a new field. Sorry. We'll use the correct
> > > field name next time.
> > >
> >
> > There isn't a "correct field name", since it hasn't been standardized. I
> > can tell you as an the ext4 maintainer, I've put things like
> >
> > Addresses-Redhat-Bugzilla: <Bugzilla #>
> >
> > or
> >
> > Addresses-Debian-Bug: <debian-bug-number>
> >
>
> This seems like a good convention. Its also nice in that it scales to
> the case where the bug is reported by multiple distros.
>
> For future, we'll use:
>
> Addresses-ChromiumOS-Bug: http://crosbug.com/<Bug #>
>
> I included the URL because its small and folks might not know where
> our bug database is.
I put "Addresses <some URL>" into the changelog. Just in the text body,
not as one of the tag:value pairs at the end of the changelog.
z:/usr/src/git26> git log | grep "Addresses http" | wc -l
121
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Mandeep Singh Baines <msb@chromium.org>
Cc: Theodore Tso <tytso@google.com>, Greg KH <greg@kroah.com>,
Paul Taysom <taysom@chromium.org>,
Paul Taysom <taysom@google.com>,
Olof Johansson <olofj@chromium.org>, Jens Axboe <axboe@kernel.dk>,
Andrew Morton <akpm@google.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: Fix mod_timer crash when removing USB sticks
Date: Thu, 12 Jan 2012 15:23:03 -0800 [thread overview]
Message-ID: <20120112152303.420e723e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120112223544.GC18166@google.com>
On Thu, 12 Jan 2012 14:35:44 -0800
Mandeep Singh Baines <msb@chromium.org> wrote:
> Theodore Tso (tytso@google.com) wrote:
> > On Thu, Jan 12, 2012 at 4:53 PM, Mandeep Singh Baines <msb@chromium.org>wrote:
> >
> > >
> > > Hi Greg,
> > >
> > > What is the conventional way of doing this? There is a lot of good
> > > data in the bug report which might be useful to reviewers. We
> > > couldn't find a de-facto way of referencing the downstream bug database
> > > so we just made up a new field. Sorry. We'll use the correct
> > > field name next time.
> > >
> >
> > There isn't a "correct field name", since it hasn't been standardized. I
> > can tell you as an the ext4 maintainer, I've put things like
> >
> > Addresses-Redhat-Bugzilla: <Bugzilla #>
> >
> > or
> >
> > Addresses-Debian-Bug: <debian-bug-number>
> >
>
> This seems like a good convention. Its also nice in that it scales to
> the case where the bug is reported by multiple distros.
>
> For future, we'll use:
>
> Addresses-ChromiumOS-Bug: http://crosbug.com/<Bug #>
>
> I included the URL because its small and folks might not know where
> our bug database is.
I put "Addresses <some URL>" into the changelog. Just in the text body,
not as one of the tag:value pairs at the end of the changelog.
z:/usr/src/git26> git log | grep "Addresses http" | wc -l
121
next prev parent reply other threads:[~2012-01-12 23:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 21:15 [PATCH] fs: Fix mod_timer crash when removing USB sticks Paul Taysom
2012-01-12 21:15 ` Paul Taysom
2012-01-12 21:38 ` Greg KH
2012-01-12 21:53 ` Mandeep Singh Baines
2012-01-12 22:02 ` Greg KH
[not found] ` <20120112215331.GB18166-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-01-12 22:11 ` Theodore Tso
2012-01-12 22:11 ` Theodore Tso
[not found] ` <CAGagf4dk4KsZSkaWTO9Yegi=_wRJsYBPgfyks1z=wMZJV8gX0w@mail.gmail.com>
2012-01-12 22:35 ` Mandeep Singh Baines
[not found] ` <20120112223544.GC18166-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-01-12 23:23 ` Andrew Morton [this message]
2012-01-12 23:23 ` Andrew Morton
[not found] ` <1326402935-31002-1-git-send-email-taysom-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-01-13 5:42 ` Josh Boyer
2012-01-13 5:42 ` Josh Boyer
[not found] ` <CA+5PVA7Yffs3-qdq6pSqDKLLngU7kBsdE92e31NnAM0=wrwp4w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-13 15:39 ` Paul Taysom
2012-01-13 15:39 ` Paul Taysom
-- strict thread matches above, loose matches on Subject: below --
2012-01-12 21:57 Paul Taysom
2012-03-16 17:36 ` Greg KH
2012-03-16 19:29 ` Paul Taysom
2012-03-16 19:43 ` Greg KH
2012-03-16 21:10 ` Theodore Tso
2012-03-17 0:06 ` Greg KH
2012-03-17 14:21 ` Alan Stern
2012-03-18 3:44 ` Ted Ts'o
2012-03-18 20:23 ` Alan Stern
2012-03-18 22:25 ` Mandeep Singh Baines
[not found] ` <CACBanvpzOdC4ns-pg1f92ptxrCJ2O=_oJhpKFD4NOB0hyF_+aA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-20 0:24 ` Paul Taysom
2012-03-20 0:24 ` Paul Taysom
2012-03-20 2:02 ` Alan Stern
2012-03-22 16:15 ` Paul Taysom
2012-01-12 19:57 Paul Taysom
2012-01-12 20:15 ` Greg KH
2012-01-13 11:28 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120112152303.420e723e.akpm@linux-foundation.org \
--to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
--cc=akpm-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=olofj-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=taysom-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=taysom-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=tytso-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.